Merge pull request #14092 from meeseeksmachine/auto-backport-of-pr-14056-on-v3.1.x

dstansby · web-flow · commit e94d54cc0d78 · 2019-04-29T22:26:40.000+01:00
Backport PR #14056 on branch v3.1.x (FIX: do not try to manage the visibility of un-drawn ticks)
diff --git a/lib/matplotlib/axis.py b/lib/matplotlib/axis.py
@@ -1095,11 +1095,6 @@ def _update_ticks(self):
             tick.set_label2(label)
         ticks = [*major_ticks, *minor_ticks]
 
-        # mark the ticks that we will not be using as not visible
-        for t in (self.minorTicks[len(minor_locs):] +
-                  self.majorTicks[len(major_locs):]):
-            t.set_visible(False)
-
         view_low, view_high = self.get_view_interval()
         if view_low > view_high:
             view_low, view_high = view_high, view_low
diff --git a/lib/matplotlib/tests/test_ticker.py b/lib/matplotlib/tests/test_ticker.py
@@ -965,9 +965,3 @@ def test_remove_overlap(remove_overlapping_locs, expected_num):
     assert len(ax.xaxis.get_minor_ticks()) == expected_num
     assert len(ax.xaxis.get_minorticklabels()) == expected_num
     assert len(ax.xaxis.get_minorticklines()) == expected_num*2
-
-    # force a draw to call _update_ticks under the hood
-    fig.canvas.draw()
-    # check that the correct number of ticks report them selves as
-    # visible
-    assert sum(t.get_visible() for t in ax.xaxis.minorTicks) == expected_num
