8000 Write error messages to logger instead of stderr · matplotlib/matplotlib@e5f700e · GitHub
[go: up one dir, main page]
Skip to content

Commit e5f700e

Browse files
timhoffmtimhoffm
committed
Write error messages to logger instead of stderr
1 parent 96522ff commit e5f700e

File tree

3 files changed

+10
-9
lines changed
  • backend_pgf.py

    • 3 files changed

    +10
    -9
    lines changed

    ‎lib/matplotlib/afm.py

    Lines changed: 7 additions & 5 deletions
    Original file line numberDiff line numberDiff line change
    @@ -38,13 +38,17 @@
    3838
    """
    3939

    4040
    from collections import namedtuple
    41+
    import logging
    4142
    import re
    42-
    import sys
    43+
    4344

    4445
    from ._mathtext_data import uni2type1
    4546
    from matplotlib.cbook import deprecated
    4647

    4748

    49+
    _log = logging.getLogger(__name__)
    50+
    51+
    4852
    # some afm files have floats where we are expecting ints -- there is
    4953
    # probably a better way to handle this (support floats, round rather
    5054
    # than truncate). But I don't know what the best approach is now and
    @@ -160,12 +164,10 @@ def _parse_header(fh):
    160164
    try:
    161165
    d[key] = headerConverters[key](val)
    162166
    except ValueError:
    163-
    print('Value error parsing header in AFM:', key, val,
    164-
    file=sys.stderr)
    167+
    _log.error('Value error parsing header in AFM: %s, %s', key, val)
    165168
    continue
    166169
    except KeyError:
    167-
    print('Found an unknown keyword in AFM header (was %r)' % key,
    168-
    file=sys.stderr)
    170+
    _log.error('Found an unknown keyword in AFM header (was %r)' % key)
    169171
    continue
    170172
    if key == b'StartCharMetrics':
    171173
    return d

    ‎lib/matplotlib/backends/backend_pdf.py

    Lines changed: 1 addition & 2 deletions
    Original file line numberDiff line numberDiff line change
    @@ -1527,8 +1527,7 @@ def writeXref(self):
    15271527
    borken = False
    15281528
    for offset, generation, name in self.xrefTable:
    15291529
    if offset is None:
    1530-
    print('No offset for object %d (%s)' % (i, name),
    1531-
    file=sys.stderr)
    1530+
    _log.error('No offset for object %d (%s)', i, name)
    15321531
    borken = True
    15331532
    else:
    15341533
    key = b"f" if name == 'the zero object' else b"n"

    ‎lib/matplotlib/backends/backend_pgf.py

    Lines changed: 2 additions & 2 deletions
    Original file line numberDiff line numberDiff line change
    @@ -756,10 +756,10 @@ def add(tmpdir):
    756756
    @staticmethod
    757757
    def cleanup_remaining_tmpdirs():
    758758
    for tmpdir in TmpDirCleaner.remaining_tmpdirs:
    759+
    error_message = "error deleting tmp directory {}".format(tmpdir)
    759760
    shutil.rmtree(
    760761
    tmpdir,
    761-
    onerror=lambda *args: print("error deleting tmp directory %s"
    762-
    % tmpdir, file=sys.stderr))
    762+
    onerror=lambda *args: _log.error(error_message))
    763763

    764764

    765765
    class FigureCanvasPgf(FigureCanvasBase):

    0 commit comments

    Comments
     (0)
    0