WIN: Fix capsule check for SetForegroundWindow

QuLogic · QuLogic · commit db478989b032 · 2024-08-07T16:51:13.000-04:00
Looking at pybind11 again, the `py::capsule::name` method returns a
`const char *`, and comparing that with a literal using `==` is
unspecified behaviour. Seemingly, this is fine on MSVC, but MinGW gcc
warns about it.
diff --git a/src/_c_internal_utils.cpp b/src/_c_internal_utils.cpp
@@ -125,7 +125,7 @@ static void
 mpl_SetForegroundWindow(py::capsule UNUSED_ON_NON_WINDOWS(handle_p))
 {
 #ifdef _WIN32
-    if (handle_p.name() != "HWND") {
+    if (strcmp(handle_p.name(), "HWND") != 0) {
         throw std::runtime_error("Handle must be a value returned from Win32_GetForegroundWindow");
     }
     HWND handle = static_cast<HWND>(handle_p.get_pointer());

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ static void`
`125`	`125`	`mpl_SetForegroundWindow(py::capsule UNUSED_ON_NON_WINDOWS(handle_p))`
`126`	`126`	`{`
`127`	`127`	`#ifdef _WIN32`
`128`		`- if (handle_p.name() != "HWND") {`
	`128`	`+ if (strcmp(handle_p.name(), "HWND") != 0) {`
`129`	`129`	`throw std::runtime_error("Handle must be a value returned from Win32_GetForegroundWindow");`
`130`	`130`	`}`
`131`	`131`	`HWND handle = static_cast<HWND>(handle_p.get_pointer());`