Try to unbreak CI by xfailing OSX Tk tests (#23095)

timhoffm · oscargus · web-flow · commit d6ee414ec175 · 2022-05-24T09:47:15.000+02:00
* Try to unbreak CI by xfailing OSX Tk tests Stopgap solution for #23094 * Update lib/matplotlib/tests/test_backend_tk.py * Update lib/matplotlib/tests/test_backend_tk.py Co-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com>
diff --git a/lib/matplotlib/tests/test_backend_tk.py b/lib/matplotlib/tests/test_backend_tk.py
@@ -37,6 +37,10 @@ def _isolated_tk_test(success_count, func=None):
         sys.platform == "linux" and not _c_internal_utils.display_is_valid(),
         reason="$DISPLAY and $WAYLAND_DISPLAY are unset"
     )
+    @pytest.mark.xfail(  # GitHub issue #23094
+        sys.platform == 'darwin',
+        reason="Tk version mismatch on OSX CI"
+    )
     @functools.wraps(func)
     def test_func():
         # even if the package exists, may not actually be importable this can
diff --git a/lib/matplotlib/tests/test_backends_interactive.py b/lib/matplotlib/tests/test_backends_interactive.py
@@ -59,6 +59,9 @@ def _get_testable_interactive_backends():
         elif env["MPLBACKEND"].startswith('wx') and sys.platform == 'darwin':
             # ignore on OSX because that's currently broken (github #16849)
             marks.append(pytest.mark.xfail(reason='github #16849'))
+        elif env["MPLBACKEND"] == "tkagg" and sys.platform == 'darwin':
+            marks.append(  # GitHub issue #23094
+                pytest.mark.xfail(reason="Tk version mismatch on OSX CI"))
         envs.append(
             pytest.param(
                 {**env, 'BACKEND_DEPS': ','.join(deps)},
@@ -236,6 +239,9 @@ def _test_thread_impl():
                 reason='PyPy does not support Tkinter threading: '
                        'https://foss.heptapod.net/pypy/pypy/-/issues/1929',
                 strict=True))
+    elif backend == "tkagg" and sys.platform == "darwin":
+        param.marks.append(  # GitHub issue #23094
+            pytest.mark.xfail("Tk version mismatch on OSX CI"))
 
 
 @pytest.mark.parametrize("env", _thread_safe_backends)
@@ -510,6 +516,10 @@ def _test_number_of_draws_script():
     elif backend == "wx":
         param.marks.append(
             pytest.mark.skip("wx does not support blitting"))
+    elif backend == "tkagg" and sys.platform == "darwin":
+        param.marks.append(  # GitHub issue #23094
+            pytest.mark.xfail("Tk version mismatch on OSX CI")
+        )
 
 
 @pytest.mark.parametrize("env", _blit_backends)
