File tree Expand file tree Collapse file tree 2 files changed +4
-12
lines changed
api/next_api_changes/development Expand file tree Collapse file tree 2 files changed +4
-12
lines changed Original file line number Diff line number Diff line change @@ -5,11 +5,4 @@ The maximum line length for new contributions has been extended from 79 characte
5
5
88 characters.
6
6
This change provides an extra 9 characters to allow code which is a single idea to fit
7
7
on fewer lines (often a single line).
8
- Other line lengths considered included 115 and 99, but ultimately 88 characters was the
9
- consensus as it is relatively conservative while still providing reasonable benefit.
10
- The ability to view side-by-side git diffs was a key point in choosing the smaller
11
- limit.
12
- Additionally, it is easier to increase the line length again than to decrease it if it
13
- was found too large.
14
8
The chosen length is the same as `black <https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length >`_.
15
- Their justifications influenced the discussion and provided a standard value.
Original file line number Diff line number Diff line change @@ -157,11 +157,10 @@ Content topics:
157
157
* Does the PR conform with the :ref: `coding_guidelines `?
158
158
* Is the :ref: `documentation <pr-documentation >` (docstrings, examples,
159
159
what's new, API changes) updated?
160
- * Is the change only reflowing code/docstrings for increased line length?
161
- Generally, such changes are discouraged when not part of other non-stylistic
162
- work because it obscures the git history of functional changes to the code.
163
- Reflowing a method or docstring as part of a larger refactor/rewrite is
164
- acceptable.
160
+ * Is the change purely stylistic? Generally, such changes are discouraged when
161
+ not part of other non-stylistic work because it obscures the git history of
162
+ functional changes to the code. Reflowing a method or docstring as part of a
163
+ larger refactor/rewrite is acceptable.
165
164
166
165
167
166
Organizational topics:
You can’t perform that action at this time.
0 commit comments