FIX: address review comments

jklymak · jklymak · commit c635fdafffdd · 2021-06-30T09:45:05.000-07:00
diff --git a/lib/matplotlib/colorbar.py b/lib/matplotlib/colorbar.py
@@ -230,14 +230,9 @@ def draw(self, renderer):
 
 class _ColorbarAxesLocator:
     """
-    Wrap any locator on the axes, or its position, to shrink the
-    inner axes if there are extend triangles at either min or max.
+    Shrink the axes if there are vertical extends.  
     """
     def __init__(self, cbar):
-        """
-        *bounds* (a ``[l, b, w, h]`` rectangle) and *transform* together
-        specify the position of the inset axes.
-        """
         self._cbar = cbar
         self._orig_locator = cbar.ax._axes_locator
 
@@ -614,10 +609,8 @@ def _do_extends(self, extendlen):
         """
         # extend lengths are fraction of the *inner* part of colorbar,
         # not the total colorbar:
-        bot = extendlen[0] if self._extend_lower() else 0
-        bot = -bot
-        top = extendlen[1] if self._extend_upper() else 0
-        top = top + 1
+        bot = 0 - (extendlen[0] if self._extend_lower() else 0)
+        top = 1 + (extendlen[1] if self._extend_upper() else 0)
 
         # xyout is the outline of the colorbar including the extend patches:
         if not self.extendrect:
diff --git a/lib/matplotlib/tests/test_colorbar.py b/lib/matplotlib/tests/test_colorbar.py
@@ -88,9 +88,9 @@ def _colorbar_extension_length(spacing):
             cax = fig.add_subplot(12, 1, i*3 + j + 1)
             # Generate the colorbar.
             Colorbar(cax, cmap=cmap, norm=norm,
-                         boundaries=boundaries, values=values,
-                         extend=extension_type, extendfrac=extendfrac,
-                         orientation='horizontal', spacing=spacing)
+                     boundaries=boundaries, values=values,
+                     extend=extension_type, extendfrac=extendfrac,
+                     orientation='horizontal', spacing=spacing)
             # Turn off text and ticks.
             cax.tick_params(left=False, labelleft=False,
                               bottom=False, labelbottom=False)
