Fix #1710. When a font doesn't have glyph names, we should synthesize them.

mdboom · mdboom · commit be1d7dd70c14 · 2013-01-28T12:41:23.000-05:00
diff --git a/src/ft2font.cpp b/src/ft2font.cpp
@@ -1616,15 +1616,17 @@ FT2Font::get_glyph_name(const Py::Tuple & args)
     _VERBOSE("FT2Font::get_glyph_name");
     args.verify_length(1);
 
-    if (!FT_HAS_GLYPH_NAMES(face))
-    {
-        throw Py::RuntimeError("Face has no glyph names");
-    }
-
     char buffer[128];
-    if (FT_Get_Glyph_Name(face, (FT_UInt) (unsigned long)Py::Int(args[0]), buffer, 128))
+    FT_UInt glyph_number = Py::Int(args[0]);
+
+    if (!FT_HAS_GLYPH_NAMES(face))
     {
-        throw Py::RuntimeError("Could not get glyph names.");
+        snprintf(buffer, 128, "uni%04x", glyph_number);
+    } else {
+        if (FT_Get_Glyph_Name(face, glyph_number, buffer, 128))
+        {
+            throw Py::RuntimeError("Could not get glyph names.");
+        }
     }
     return Py::String(buffer);
 }
