BUG: fix test error when ghostscript not installed

matthew-brett · matthew-brett · commit bd852df60e5e · 2014-07-26T13:50:22.000-07:00
Confusingly checkdep_ghostscript returns a tuple rather than a bool, so
we need to check an element of the tuple to see whether ghostscript is
installed.  Put the test into a decorator in case we need it for another
test.
diff --git a/lib/matplotlib/tests/test_backend_ps.py b/lib/matplotlib/tests/test_backend_ps.py
@@ -7,11 +7,20 @@
 import re
 
 import six
-from nose.plugins.skip import SkipTest
 
 import matplotlib
 import matplotlib.pyplot as plt
-from matplotlib.testing.decorators import cleanup
+from matplotlib.testing.decorators import cleanup, knownfailureif
+
+
+needs_ghostscript = knownfailureif(
+    matplotlib.checkdep_ghostscript()[0] is None,
+    "This test needs a ghostscript installation")
+
+
+needs_tex = knownfailureif(
+    not matplotlib.checkdep_tex(),
+    "This test needs a TeX installation")
 
 
 def _test_savefig_to_stringio(format='ps'):
@@ -50,18 +59,15 @@ def test_savefig_to_stringio():
 
 
 @cleanup
+@needs_ghostscript
 def test_savefig_to_stringio_with_distiller():
-    if not matplotlib.checkdep_ghostscript():
-        raise SkipTest("This test requires a GhostScript installation")
     matplotlib.rcParams['ps.usedistiller'] = 'ghostscript'
     _test_savefig_to_stringio()
 
 
 @cleanup
+@needs_tex
 def test_savefig_to_stringio_with_usetex():
-    if not matplotlib.checkdep_tex():
-        raise SkipTest("This test requires a TeX installation")
-
     matplotlib.rcParams['text.latex.unicode'] = True
     matplotlib.rcParams['text.usetex'] = True
     _test_savefig_to_stringio()
@@ -73,10 +79,8 @@ def test_savefig_to_stringio_eps():
 
 
 @cleanup
+@needs_tex
 def test_savefig_to_stringio_with_usetex_eps():
-    if not matplotlib.checkdep_tex():
-        raise SkipTest("This test requires a TeX installation")
-
     matplotlib.rcParams['text.latex.unicode'] = True
     matplotlib.rcParams['text.usetex'] = True
     _test_savefig_to_stringio(format='eps')
