Merge pull request #1323 from cgohlke/patch-13

dmcdougall · dmcdougall · commit b6cf11548d95 · 2012-10-18T11:02:05.000-07:00
Work around a huge memory leak in PySide on Python 3
diff --git a/lib/matplotlib/backends/backend_qt4agg.py b/lib/matplotlib/backends/backend_qt4agg.py
@@ -4,6 +4,7 @@
 from __future__ import division, print_function
 
 import os, sys
+import ctypes
 
 import matplotlib
 from matplotlib.figure import Figure
@@ -15,6 +16,10 @@
 
 DEBUG = False
 
+_decref = ctypes.pythonapi.Py_DecRef
+_decref.argtypes = [ctypes.py_object]
+_decref.restype = None
+
 
 def new_figure_manager( num, *args, **kwargs ):
     """
@@ -95,6 +100,8 @@ def paintEvent( self, e ):
             else:
                 stringBuffer = self.renderer._renderer.tostring_argb()
 
+            refcnt = sys.getrefcount(stringBuffer)
+
             qImage = QtGui.QImage(stringBuffer, self.renderer.width,
                                   self.renderer.height,
                                   QtGui.QImage.Format_ARGB32)
@@ -106,6 +113,14 @@ def paintEvent( self, e ):
                 p.setPen( QtGui.QPen( QtCore.Qt.black, 1, QtCore.Qt.DotLine ) )
                 p.drawRect( self.rect[0], self.rect[1], self.rect[2], self.rect[3] )
             p.end()
+
+            # This works around a bug in PySide 1.1.2 on Python 3.x,
+            # where the reference count of stringBuffer is incremented
+            # but never decremented by QImage.
+            # TODO: revert PR #1323 once the issue is fixed in PySide.
+            del qImage
+            if refcnt != sys.getrefcount(stringBuffer):
+                _decref(stringBuffer)
         else:
             bbox = self.blitbox
             l, b, r, t = bbox.extents
