Add update parameter to clear selector method to make it more generic and simplify code

ericpre · ericpre · commit b093bde07ea1 · 2022-01-09T11:07:10.000Z
diff --git a/lib/matplotlib/widgets.py b/lib/matplotlib/widgets.py
@@ -2039,11 +2039,22 @@ def get_visible(self):
         property(lambda self: self._visible,
                  lambda self, value: setattr(self, "_visible", value)))
 
-    def clear(self):
-        """Clear the selection and set the selector ready to make a new one."""
+    def clear(self, update=True):
+        """
+        Clear the selection and set the selector ready to make a new one.
+
+        Parameters
+        ----------
+        update : bool
+            Call the `update` method of the selector to remove the selector
+            from the figure. If False, the selector will be removed at the
+            next draw.
+
+        """
         self._selection_completed = False
         self.set_visible(False)
-        self.update()
+        if update:
+            self.update()
 
     @property
     def artists(self):
@@ -3046,12 +3057,10 @@ def _release(self, event):
         # either x or y-direction
         minspanxy = (spanx <= self.minspanx or spany <= self.minspany)
         if (self._drawtype != 'none' and minspanxy):
-            for artist in self.artists:
-                artist.set_visible(False)
             if self._selection_completed:
                 # Call onselect, only when the selection is already existing
                 self.onselect(self._eventpress, self._eventrelease)
-            self._selection_completed = False
+            self.clear(update=False)
         else:
             self.onselect(self._eventpress, self._eventrelease)
             self._selection_completed = True
