Merge pull request #14593 from anntzer/secondarycolor

ksunden · web-flow · commit a861b8af82cc · 2023-07-07T19:01:19.000-05:00
Simplify SecondaryAxis.set_color.
diff --git a/lib/matplotlib/axes/_secondary_axes.py b/lib/matplotlib/axes/_secondary_axes.py
@@ -235,16 +235,12 @@ def set_color(self, color):
         ----------
         color : color
         """
-        if self._orientation == 'x':
-            self.tick_params(axis='x', colors=color)
-            self.spines.bottom.set_color(color)
-            self.spines.top.set_color(color)
-            self.xaxis.label.set_color(color)
-        else:  # 'y'
-            self.tick_params(axis='y', colors=color)
-            self.spines.left.set_color(color)
-            self.spines.right.set_color(color)
-            self.yaxis.label.set_color(color)
+        axis = self._axis_map[self._orientation]
+        axis.set_tick_params(colors=color)
+        for spine in self.spines.values():
+            if spine.axis is axis:
+                spine.set_color(color)
+        axis.label.set_color(color)
 
 
 _secax_docstring = '''
diff --git a/lib/matplotlib/tests/test_axes.py b/lib/matplotlib/tests/test_axes.py
@@ -8784,3 +8784,13 @@ def test_tick_param_labelfont():
     plt.title('Title in sans-serif')
     for text in ax.get_xticklabels():
         assert text.get_fontfamily()[0] == 'monospace'
+
+
+def test_set_secondary_axis_color():
+    fig, ax = plt.subplots()
+    sax = ax.secondary_xaxis("top", color="red")
+    assert mcolors.same_color(sax.spines["bottom"].get_edgecolor(), "red")
+    assert mcolors.same_color(sax.spines["top"].get_edgecolor(), "red")
+    assert mcolors.same_color(sax.xaxis.get_tick_params()["color"], "red")
+    assert mcolors.same_color(sax.xaxis.get_tick_params()["labelcolor"], "red")
+    assert mcolors.same_color(sax.xaxis.label.get_color(), "red")
