ENH: Add support for Axes3D.set_pb_aspect

eric-wieser · tacaswell · commit a5a245599cc5 · 2020-05-27T12:41:45.000-04:00
This only keeps the pb related changes from the original commit.
diff --git a/lib/mpl_toolkits/mplot3d/axes3d.py b/lib/mpl_toolkits/mplot3d/axes3d.py
@@ -91,6 +91,11 @@ def __init__(
         self.zz_viewLim = Bbox.unit()
         self.xy_dataLim = Bbox.unit()
         self.zz_dataLim = Bbox.unit()
+        if 'pb_aspect' in kwargs:
+            self.pb_aspect = np.asarray(kwargs['pb_aspect'])
+        else:
+            # chosen for similarity with the previous initial view
+            self.pb_aspect = np.array([4, 4, 3]) / 3.5
         # inhibit autoscale_view until the axes are defined
         # they can't be defined until Axes.__init__ has been called
         self.view_init(self.initial_elev, self.initial_azim)
@@ -348,6 +353,9 @@ def set_anchor(self, anchor, share=False):
             ax._anchor = anchor
             ax.stale = True
 
+    def set_pb_aspect(self, pb_aspect, zoom=1):
+        self.pb_aspect = pb_aspect * 1.8 * zoom / proj3d.mod(pb_aspect)
+
     def apply_aspect(self, position=None):
         if position is None:
             position = self.get_position(original=True)
@@ -974,7 +982,12 @@ def set_proj_type(self, proj_type):
     def get_proj(self):
         """Create the projection matrix from the current viewing position."""
         # chosen for similarity with the initial view before gh-8896
-        pb_aspect = np.array([4, 4, 3]) / 3.5
+
+        # elev stores the elevation angle in the z plane
+        # azim stores the azimuth angle in the x,y plane
+        #
+        # dist is the distance of the eye viewing point from the object
+        # point.
 
         relev, razim = np.pi * self.elev/180, np.pi * self.azim/180
 
@@ -985,10 +998,10 @@ def get_proj(self):
         # transform to uniform world coordinates 0-1, 0-1, 0-1
         worldM = proj3d.world_transformation(xmin, xmax,
                                              ymin, ymax,
-                                             zmin, zmax, pb_aspect=pb_aspect)
+                                             zmin, zmax, pb_aspect=self.pb_aspect)
 
         # look into the middle of the new coordinates
-        R = pb_aspect / 2
+        R = self.pb_aspect / 2
 
         xp = R[0] + np.cos(razim) * np.cos(relev) * self.dist
         yp = R[1] + np.sin(razim) * np.cos(relev) * self.dist
