flip subfigures axes to match subplots

saranti · saranti · commit a25c1bd0becd · 2024-06-10T16:42:14.000+10:00
diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py
@@ -1583,9 +1583,9 @@ def subfigures(self, nrows=1, ncols=1, squeeze=True,
                       left=0, right=1, bottom=0, top=1)
 
         sfarr = np.empty((nrows, ncols), dtype=object)
-        for i in range(ncols):
-            for j in range(nrows):
-                sfarr[j, i] = self.add_subfigure(gs[j, i], **kwargs)
+        for i in range(nrows):
+            for j in range(ncols):
+                sfarr[i, j] = self.add_subfigure(gs[i, j], **kwargs)
 
         if self.get_layout_engine() is None and (wspace is not None or
                                                  hspace is not None):
diff --git a/lib/matplotlib/tests/test_figure.py b/lib/matplotlib/tests/test_figure.py
@@ -1733,3 +1733,14 @@ def test_warn_colorbar_mismatch():
     subfig3_1.colorbar(im3_2)   # should not warn
     with pytest.warns(UserWarning, match="different Figure"):
         subfig3_1.colorbar(im4_1)
+
+
+@check_figures_equal(extensions=['png'])
+def test_subfigure_row_order(fig_test, fig_ref):
+    # Test that subfigures are drawn in row major order.
+    sf_arr_ref = fig_ref.subfigures(4, 3)
+    for i, sf in enumerate(sf_arr_ref.ravel()):
+        sf.suptitle(i)
+    fig_test.subfigures(4, 3)
+    for i, sf in enumerate(fig_test.subfigs):
+        sf.suptitle(i)
