MNT: simplify getting the first element

tacaswell · tacaswell · commit a023ecf16b1c · 2019-09-01T12:49:23.000-04:00
Use `safe_first_element` from cbook which does the `next(iter(x))`
dance to get the first element of an object (as defined by what you
get when you iterate over it).
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -2138,33 +2138,14 @@ def _convert_dx(dx, x0, xconv, convert):
             # removes the units from unit packages like `pint` that
             # wrap numpy arrays.
             try:
-                x0 = x0[0]
+                x0 = cbook.safe_first_element(x0)
             except (TypeError, IndexError, KeyError):
-                try:
-                    xx = np.atleast_1d(np.asarray(x0))
-                    if len(xx) == 1:
-                        # this keeps units for singletons...
-                        x0 = x0
-                    else:
-                        # fallback for objects with length, but strange
-                        # ways of indexing (i.e. pandas)
-                        x0 = xx[0]
-                except:
-                    # generic except.  Think this should never happen, but...
-                    x0 = x0
+                x0 = x0
 
             try:
-                x = xconv[0]
+                x = cbook.safe_first_element(xconv)
             except (TypeError, IndexError, KeyError):
-                try:
-                    xx = np.atleast_1d(np.asarray(xconv))
-                    if len(xx) == 1:
-                        x = xconv
-                    else:
-                        x = xx[0]
-                except:
-                    # generic except.  Think this should never happen, but...
-                    x = xconv
+                x = xconv
 
             delist = False
             if not np.iterable(dx):
