MNT: change from == False to == 0

tacaswell · tacaswell · commit 9b37674a187c · 2018-01-06T23:56:18.000-05:00
https://docs.python.org/3/library/stdtypes.html#boolean-values This makes the linter happy and is no change in behavior.
diff --git a/lib/matplotlib/backend_bases.py b/lib/matplotlib/backend_bases.py
@@ -1370,9 +1370,12 @@ def _on_timer(self):
         '''
         for func, args, kwargs in self.callbacks:
             ret = func(*args, **kwargs)
-            # docstring above explains why we use `if ret == False` here,
+            # docstring above explains why we use `if ret == 0` here,
             # instead of `if not ret`.
-            if ret == False:
+            # This will also catch `ret == False` as `False == 0`
+            # but does not annoy the linters
+            # https://docs.python.org/3/library/stdtypes.html#boolean-values
+            if ret == 0:
                 self.callbacks.remove((func, args, kwargs))
 
         if len(self.callbacks) == 0:
