Fix 999.9... edge case in ticker.EngFormatter for negative numbers

Lewn · web-flow · commit 8e17289f0ec8 · 2018-09-06T17:36:24.000+02:00
diff --git a/lib/matplotlib/ticker.py b/lib/matplotlib/ticker.py
@@ -1268,7 +1268,8 @@ def format_eng(self, num):
         # Taking care of the cases like 999.9..., which may be rounded to 1000
         # instead of 1 k.  Beware of the corner case of values that are beyond
         # the range of SI prefixes (i.e. > 'Y').
-        if float(format(mant, fmt)) >= 1000 and pow10 < max(self.ENG_PREFIXES):
+        _fmant = float(format(mant, fmt))
+        if (_fmant >= 1000 or _fmant <= -1000) and pow10 < max(self.ENG_PREFIXES):
             mant /= 1000
             pow10 += 3
 

Original file line number	Diff line number	Diff line change
`@@ -1268,7 +1268,8 @@ def format_eng(self, num):`
`1268`	`1268`	`# Taking care of the cases like 999.9..., which may be rounded to 1000`
`1269`	`1269`	`# instead of 1 k. Beware of the corner case of values that are beyond`
`1270`	`1270`	`# the range of SI prefixes (i.e. > 'Y').`
`1271`		`- if float(format(mant, fmt)) >= 1000 and pow10 < max(self.ENG_PREFIXES):`
	`1271`	`+ _fmant = float(format(mant, fmt))`
	`1272`	`+ if (_fmant >= 1000 or _fmant <= -1000) and pow10 < max(self.ENG_PREFIXES):`
`1272`	`1273`	`mant /= 1000`
`1273`	`1274`	`pow10 += 3`
`1274`	`1275`