Backport PR #21833: Enforce backport conditions on v*-doc branches

tacaswell · tacaswell · commit 8ae93c17bd01 · 2022-01-12T16:06:25.000-05:00
Merge pull request #21833 from QuLogic/clean-doc-backports CI: Enforce backport conditions on v*-doc branches
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -103,7 +103,15 @@ commands:
     steps:
       - run:
           name: Install Matplotlib
-          command: python -m pip install --user -ve .
+          command: |
+            if [[ "$CIRCLE_BRANCH" == v*-doc ]]; then
+              # The v*-doc branches must build against the specified release.
+              version=${CIRCLE_BRANCH%-doc}
+              version=${version#v}
+              python -m pip install matplotlib==${version}
+            else
+              python -m pip install --user -ve .
+            fi
       - save_cache:
           key: build-deps-1
           paths:
diff --git a/.github/workflows/clean_pr.yml b/.github/workflows/clean_pr.yml
@@ -19,4 +19,25 @@ jobs:
             printf 'The following files were both added and deleted in this PR:\n%s\n' "$ad"
             exit 1
           fi
-
+      - name: Check for added-and-modified images
+        run: |
+          git fetch --quiet origin "$GITHUB_BASE_REF"
+          base="$(git merge-base "origin/$GITHUB_BASE_REF" 'HEAD^2')"
+          am="$(git log "$base..HEAD^2" --pretty=tformat: --name-status --diff-filter=AM |
+                cut --fields 2 | sort | uniq --repeated |
+                grep -E '\.(png|pdf|ps|eps|svg)' || true)"
+          if [[ -n "$am" ]]; then
+            printf 'The following images were both added and modified in this PR:\n%s\n' "$am"
+            exit 1
+          fi
+      - name: Check for invalid backports to -doc branches
+        if: endsWith(github.base_ref, '-doc')
+        run: |
+          git fetch --quiet origin "$GITHUB_BASE_REF"
+          base="$(git merge-base "origin/$GITHUB_BASE_REF" 'HEAD^2')"
+          lib="$(git log "$base..HEAD^2" --pretty=tformat: --name-status -- lib src |
+                 cut --fields 2 | sort || true)"
+          if [[ -n "$lib" ]]; then
+            printf 'Changes to the following files have no effect and should not be backported:\n%s\n' "$lib"
+            exit 1
+          fi
