8000 Merge pull request #29416 from meeseeksmachine/auto-backport-of-pr-29… · matplotlib/matplotlib@8721632 · GitHub
[go: up one dir, main page]

Skip to content

Commit 8721632

Browse files
authored
Merge pull request #29416 from meeseeksmachine/auto-backport-of-pr-29382-on-v3.10.x
Backport PR #29382 on branch v3.10.x (Fix title position for polar plots)
2 parents 103b6b6 + f9e3c74 commit 8721632

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

lib/matplotlib/axes/_base.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3071,9 +3071,8 @@ def _update_title_position(self, renderer):
30713071
top = -np.inf
30723072
for ax in axs:
30733073
bb = None
3074-
xticklabel_top = any(tick.label2.get_visible() for tick in
3075-
[ax.xaxis.majorTicks[0], ax.xaxis.minorTicks[0]])
3076-
if (xticklabel_top or ax.xaxis.get_label_position() == 'top'):
3074+
if (ax.xaxis.get_ticks_position() in ['top', 'unknown'] or
3075+
ax.xaxis.get_label_position() == 'top'):
30773076
bb = ax.xaxis.get_tightbbox(renderer)
30783077
if bb is None:
30793078
# Extent of the outline for colorbars, of the axes otherwise.
Loading

lib/matplotlib/tests/test_polar.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,13 @@ def test_polar_rlabel_position():
220220
ax.tick_params(rotation='auto')
221221

222222

223+
@image_comparison(['polar_title_position.png'], style='mpl20')
224+
def test_polar_title_position():
225+
fig = plt.figure()
226+
ax = fig.add_subplot(projection='polar')
227+
ax.set_title('foo')
228+
229+
223230
@image_comparison(['polar_theta_wedge'], style='default')
224231
def test_polar_theta_limits():
225232
r = np.arange(0, 3.0, 0.01)

0 commit comments

Comments
 (0)
0