8000 Don't use 'renderer' argument to Axis._update_ticks. · matplotlib/matplotlib@7cd5051 · GitHub
[go: up one dir, main page]

Skip to content

Commit 7cd5051

Browse files
committed
Don't use 'renderer' argument to Axis._update_ticks.
It was not being used. Now we warn that it will be removed in 3.1. Note that the completely different AxisArtist._update_ticks does use its renderer argument.
1 parent 2ac8e47 commit 7cd5051

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

lib/matplotlib/axis.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -989,7 +989,7 @@ def get_ticklabel_extents(self, renderer):
989989
of the axes.
990990
"""
991991

992-
ticks_to_draw = self._update_ticks(renderer)
992+
ticks_to_draw = self._update_ticks()
993993
ticklabelBoxes, ticklabelBoxes2 = self._get_tick_bboxes(ticks_to_draw,
994994
renderer)
995995

@@ -1012,13 +1012,17 @@ def get_smart_bounds(self):
10121012
"""get whether the axis has smart bounds"""
10131013
return self._smart_bounds
10141014

1015-
def _update_ticks(self, renderer):
1015+
def _update_ticks(self, renderer=None):
10161016
"""
10171017
Update ticks (position and labels) using the current data
10181018
interval of the axes. Returns a list of ticks that will be
10191019
drawn.
10201020
"""
10211021

1022+
if renderer is not None:
1023+
cbook.warn_deprecated("Axis._update_ticks should be called with"
1024+
" no arguments; the 'renderer' argument"
1025+
" is ignored and will be removed in 3.1")
10221026
interval = self.get_view_interval()
10231027
tick_tups = list(self.iter_ticks()) # iter_ticks calls the locator
10241028
if self._smart_bounds and tick_tups:
@@ -1135,7 +1139,7 @@ def get_tightbbox(self, renderer):
11351139
if not self.get_visible():
11361140
return
11371141

1138-
ticks_to_draw = self._update_ticks(renderer)
1142+
ticks_to_draw = self._update_ticks()
11391143

11401144
self._update_label_position(renderer)
11411145

@@ -1180,7 +1184,7 @@ def draw(self, renderer, *args, **kwargs):
11801184
return
11811185
renderer.open_group(__name__)
11821186

1183-
ticks_to_draw = self._update_ticks(renderer)
1187+
ticks_to_draw = self._update_ticks()
11841188
ticklabelBoxes, ticklabelBoxes2 = self._get_tick_bboxes(ticks_to_draw,
11851189
renderer)
11861190

@@ -1921,7 +1925,7 @@ def _get_tick_boxes_siblings(self, renderer):
19211925
grp = self.figure._align_xlabel_grp
19221926
# if we want to align labels from other axes:
19231927
for nn, axx in enumerate(grp.get_siblings(self.axes)):
1924-
ticks_to_draw = axx.xaxis._update_ticks(renderer)
1928+
ticks_to_draw = axx.xaxis._update_ticks()
19251929
tlb, tlb2 = axx.xaxis._get_tick_bboxes(ticks_to_draw, renderer)
19261930
bboxes.extend(tlb)
19271931
bboxes2.extend(tlb2)
@@ -2294,7 +2298,7 @@ def _get_tick_boxes_siblings(self, renderer):
22942298
grp = self.figure._align_ylabel_grp
22952299
# if we want to align labels from other axes:
22962300
for axx in grp.get_siblings(self.axes):
2297-
ticks_to_draw = axx.yaxis._update_ticks(renderer)
2301+
ticks_to_draw = axx.yaxis._update_ticks()
22982302
tlb, tlb2 = axx.yaxis._get_tick_bboxes(ticks_to_draw, renderer)
22992303
bboxes.extend(tlb)
23002304
bboxes2.extend(tlb2)

0 commit comments

Comments
 (0)
0