Addressing review comments

melissawm · melissawm · commit 7ad9bbd0f385 · 2022-08-28T15:35:04.000-03:00
diff --git a/doc/devel/coding_guide.rst b/doc/devel/coding_guide.rst
@@ -13,19 +13,19 @@
 Pull request guidelines
 ***********************
 
-Pull requests (PRs) are the mechanism for contributing to Matplotlib's code and
-documentation.
+`Pull requests (PRs) on GitHub <https://docs.github.com/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests>`__
+are the mechanism for contributing to Matplotlib's code and documentation.
 
 It is recommended to check that your contribution complies with the following
 rules before submitting a pull request:
 
 * If your pull request addresses an issue, please use the title to describe the
-  issue and mention the issue number in the pull request description to ensure
-  that a link is created to the original issue.
-
-* All public methods should have informative docstrings with sample usage when
-  appropriate. Use the `numpy docstring standard
-  <https://numpydoc.readthedocs.io/en/latest/format.html>`_.
+  issue (e.g. "Add ability to plot timedeltas") and mention the issue number
+  in the pull request description to ensure that a link is created to the
+  original issue (e.g. "Closes #8869" or "Fixes #8869"). This will ensure the
+  original issue mentioned is automatically closed when your PR is merged. See
+  `the GitHub documentation <https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue>`__
+  for more details.
 
 * Formatting should follow the recommendations of PEP8_, as enforced by
   flake8_.  You can check flake8 compliance from the command line with ::
@@ -45,6 +45,9 @@ rules before submitting a pull request:
   .. __: https://github.com/psf/black/issues/148
   .. __: https://github.com/psf/black/issues/1984
 
+* All public methods should have informative docstrings with sample usage when
+  appropriate. Use the :ref:`docstring standards <writing-docstrings>`.
+
 * Each high-level plotting function should have a simple example in the
   ``Example`` section of the docstring.  This should be as simple as possible
   to demonstrate the method.  More complex examples should go in the
diff --git a/doc/devel/development_workflow.rst b/doc/devel/development_workflow.rst
@@ -19,8 +19,9 @@ In what follows we'll refer to the upstream Matplotlib ``main`` branch, as
   branch".
 * Name your branch for the purpose of the changes - e.g.
   ``bugfix-for-issue-14`` or ``refactor-database-code``.
-* If you get stuck, reach out on Gitter or the Mailing list.
-* Ask for code review!
+* If you get stuck, reach out on Gitter or
+  `discourse <https://discourse.matplotlib.org>`__.
+* Ask for a code review!
 
 This way of working helps to keep work well organized, with readable history.
 This in turn makes it easier for project maintainers (that might be you) to see
@@ -155,8 +156,8 @@ Say if there is anything you'd like particular attention for - like a
 complicated change or some code you are not happy with.
 
 If you don't think your request is ready to be merged, just say so in your pull
-request message.  This is still a good way of getting some preliminary code
-review.
+request message and use the "Draft PR" feature of GitHub. This is a good way of
+getting some preliminary code review.
 
 Some other things you might want to do
 ======================================
@@ -173,9 +174,6 @@ To see a linear list of commits for this branch::
 
    git log
 
-You can also look at the `network graph visualizer <https://github.com/matplotlib/matplotlib/network>`_ for your github
-repo.
-
 .. _rebase-on-trunk:
 
 Rebasing on trunk
