FIX/API: set_canvas does not mark figure as stale

tacaswell · tacaswell · commit 77e815e16db1 · 2015-09-26T18:45:23.000-04:00
This is not part of the state of the figure that will trigger a
re-drawing.

If the user resets the canvas, it is their responsibility to schedule
the redraw.
diff --git a/lib/matplotlib/backend_bases.py b/lib/matplotlib/backend_bases.py
@@ -1678,12 +1678,6 @@ class FigureCanvasBase(object):
                          'Tagged Image File Format')
 
     def __init__(self, figure):
-        # put this first to make sure that we prevent any attempts to
-        # re-draw while we are constructing the canvas.
-        # See issue #5094, this only trigged on saving a png when:
-        #  - using a non-agg backend
-        #  - in interactive mode
-        #  - not bunching `draw_idle` calls (ex not in IPython)
         self._is_idle_drawing = True
         self._is_saving = False
         figure.set_canvas(self)
diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py
@@ -560,7 +560,6 @@ def set_canvas(self, canvas):
         ACCEPTS: a FigureCanvas instance
         """
         self.canvas = canvas
-        self.stale = True
 
     def hold(self, b=None):
         """
