8000 Code review comments · matplotlib/matplotlib@74d2f59 · GitHub
[go: up one dir, main page]

Skip to content

Commit 74d2f59

Browse files
Code review comments
1 parent c76a9f0 commit 74d2f59

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

lib/mpl_toolkits/mplot3d/axis3d.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -418,10 +418,8 @@ def draw_pane(self, renderer):
418418
renderer.close_group('pane3d')
419419

420420
def _axmask(self):
421-
info = self._axinfo
422-
index = info["i"]
423421
axmask = [True, True, True]
424-
axmask[index] = False
422+
axmask[self._axinfo["i"]] = False
425423
return axmask
426424

427425
def _draw_ticks(self, renderer, edgep1, centers, deltas, highs,
@@ -470,6 +468,7 @@ def _draw_offset_text(self, renderer, edgep1, edgep2, labeldeltas, centers,
470468
info = self._axinfo
471469
index = info["i"]
472470
juggled = info["juggled"]
471+
tickdir = info["tickdir"]
473472

474473
# Which of the two edge points do we want to
475474
# use for locating the offset text?
@@ -500,14 +499,14 @@ def _draw_offset_text(self, renderer, edgep1, edgep2, labeldeltas, centers,
500499
# using the wrong reference points).
501500
#
502501
# (TT, FF, TF, FT) are the shorthand for the tuple of
503-
# (centpt[info['tickdir']] <= pep[info['tickdir'], outerindex],
502+
# (centpt[tickdir] <= pep[tickdir, outerindex],
504503
# centpt[index] <= pep[index, outerindex])
505504
#
506505
# Three-letters (e.g., TFT, FTT) are short-hand for the array of bools
507506
# from the variable 'highs'.
508507
# ---------------------------------------------------------------------
509508
centpt = proj3d.proj_transform(*centers, self.axes.M)
510-
if centpt[info['tickdir']] > pep[info['tickdir'], outerindex]:
509+
if centpt[tickdir] > pep[tickdir, outerindex]:
511510
# if FT and if highs has an even number of Trues
512511
if (centpt[index] <= pep[index, outerindex]
513512
and np.count_nonzero(highs) % 2 == 0):
@@ -536,7 +535,7 @@ def _draw_offset_text(self, renderer, edgep1, edgep2, labeldeltas, centers,
536535

537536
def _draw_labels(self, renderer, edgep1, edgep2, labeldeltas, centers,
538537
dx, dy):
539-
info = self._axinfo
538+
label = self._axinfo["label"]
540539

541540
# Draw labels
542541
lxyz = 0.5 * (edgep1 + edgep2)
@@ -546,9 +545,9 @@ def _draw_labels(self, renderer, edgep1, edgep2, labeldeltas, centers,
546545
if self.get_rotate_label(self.label.get_text()):
547546
angle = art3d._norm_text_angle(np.rad2deg(np.arctan2(dy, dx)))
548547
self.label.set_rotation(angle)
549-
self.label.set_va(info['label']['va'])
550-
self.label.set_ha(info['label']['ha'])
551-
self.label.set_rotation_mode(info['label']['rotation_mode'])
548+
self.label.set_va(label['va'])
549+
self.label.set_ha(label['ha'])
550+
self.label.set_rotation_mode(label['rotation_mode'])
5 4557 52551
self.label.draw(renderer)
553552

554553
@artist.allow_rasterization

0 commit comments

Comments
 (0)
0