Nicer axes names in selector for figure options.

anntzer · anntzer · commit 710cb7f4796c · 2015-12-12T18:07:56.000-08:00
Replace the old label, which included the legthy repr of the axes object, to a nicer label which emphasizes the title or axes labels (depending on what is present). Also drops the use of the label of the Axes object itself, for which I haven't found any other reference or use in general. (Another option would be to use solely `Axes.get_label()` when defined, as this doesn't seem to have any other use.) See #5468.
diff --git a/lib/matplotlib/backends/backend_qt5.py b/lib/matplotlib/backends/backend_qt5.py
@@ -619,22 +619,16 @@ def edit_parameters(self):
                 titles = []
                 for axes in allaxes:
                     title = axes.get_title()
+                    xlabel = axes.get_xlabel()
                     ylabel = axes.get_ylabel()
-                    label = axes.get_label()
                     if title:
-                        fmt = "%(title)s"
-                        if ylabel:
-                            fmt += ": %(ylabel)s"
-                        fmt += " (%(axes_repr)s)"
-                    elif ylabel:
-                        fmt = "%(axes_repr)s (%(ylabel)s)"
-                    elif label:
-                        fmt = "%(axes_repr)s (%(label)s)"
+                        name = title
+                    elif xlabel and ylabel:
+                        name = "{} - {}".format(xlabel, ylabel)
                     else:
-                        fmt = "%(axes_repr)s"
-                    titles.append(fmt % dict(title=title,
-                                         ylabel=ylabel, label=label,
-                                         axes_repr=repr(axes)))
+                        name = "<anonymous {} (id: {:#x})>".format(
+                            type(axes).__name__, id(axes))
+                    titles.append(name)
                 item, ok = QtWidgets.QInputDialog.getItem(
                     self.parent, 'Customize', 'Select axes:', titles, 0, False)
                 if ok:
