MNT: if process dies, make sure we close the streams

tacaswell · tacaswell · commit 6f16cb2032f9 · 2022-04-06T09:27:50.000-04:00
This prevents pytest from failing other test due to auto-closed resources.
diff --git a/lib/matplotlib/testing/compare.py b/lib/matplotlib/testing/compare.py
@@ -147,6 +147,11 @@ def __call__(self, orig, dest):
             weakref.finalize(self._tmpdir, self.__del__)
         if (not self._proc  # First run.
                 or self._proc.poll() is not None):  # Inkscape terminated.
+            if self._proc is not None and self._proc.poll() is not None:
+                for stream in filter(None, [self._proc.stdin,
+                                            self._proc.stdout,
+                                            self._proc.stderr]):
+                    stream.close()
             env = {
                 **os.environ,
                 # If one passes e.g. a png file to Inkscape, it will try to
