TST: add test

jklymak · jklymak · commit 6e15b71ea546 · 2019-01-09T10:26:28.000-08:00
diff --git a/lib/matplotlib/tests/test_ticker.py b/lib/matplotlib/tests/test_ticker.py
@@ -183,6 +183,10 @@ def test_switch_to_autolocator(self):
         loc = mticker.LogLocator(subs="all")
         assert_array_equal(loc.tick_values(0.45, 0.55),
                            [0.44, 0.46, 0.48, 0.5, 0.52, 0.54, 0.56])
+        # check that we *skip* 1.0, and 10, because this is a minor locator
+        loc = mticker.LogLocator(subs=np.arange(2, 10))
+        assert not 1.0 in loc.tick_values(0.9, 20.)
+        assert not 10.0 in loc.tick_values(0.9, 20.)
 
     def test_set_params(self):
         """
diff --git a/lib/matplotlib/ticker.py b/lib/matplotlib/ticker.py
@@ -2248,6 +2248,7 @@ def tick_values(self, vmin, vmax):
                 ticklocs = b ** decades
 
         _log.debug('ticklocs %r', ticklocs)
+        print('subs', subs, have_subs, ticklocs)
         if (len(subs) > 1
                 and stride == 1
                 and ((vmin <= ticklocs) & (ticklocs <= vmax)).sum() <= 1):
@@ -2258,6 +2259,7 @@ def tick_values(self, vmin, vmax):
             # Don't overstrike the major labels.
             ticklocs = ticklocs[
                 ~is_close_to_int(np.log(ticklocs) / np.log(b))]
+            print('ticklocs', ticklocs)
             return ticklocs
         return self.raise_if_exceeds(ticklocs)
 
