8000 Merge pull request #23464 from anntzer/mc · matplotlib/matplotlib@699ad65 · GitHub
[go: up one dir, main page]

Skip to content

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 699ad65

Browse files
authored
Merge pull request #23464 from anntzer/mc
Deprecate macos close handler.
2 parents d38af6a + 7f163ca commit 699ad65

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
``FigureManagerMac.close`` is deprecated
2+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

lib/matplotlib/backends/backend_macosx.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,10 +158,14 @@ def __init__(self, canvas, num):
158158
self.show()
159159
self.canvas.draw_idle()
160160

161-
def close(self):
161+
def _close_button_pressed(self):
162162
Gcf.destroy(self)
163163
self.canvas.flush_events()
164164

165+
@_api.deprecated("3.6")
166+
def close(self):
167+
return self._close_button_pressed()
168+
165169
def show(self):
166170
if not self._shown:
167171
self._show()

src/_macosx.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1132,7 +1132,7 @@ - (NSRect)constrainFrameRect:(NSRect)rect toScreen:(NSScreen*)screen
11321132

11331133
- (BOOL)closeButtonPressed
11341134
{
1135-
gil_call_method(manager, "close");
1135+
gil_call_method(manager, "_close_button_pressed");
11361136
return YES;
11371137
}
11381138

0 commit comments

Comments
 (0)
0