8000 Fix potential memory leak · matplotlib/matplotlib@5f329e3 · GitHub
[go: up one dir, main page]

Skip to content

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5f329e3

Browse files
authored
Fix potential memory leak
When realloc failed, the original pointer was lost (set to NULL).
1 parent e73dfe1 commit 5f329e3

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/_path.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1053,12 +1053,14 @@ char *__append_to_string(char *p, char **buffer, size_t *buffersize,
10531053
return NULL;
10541054
}
10551055
if ((size_t)(p - *buffer) >= *buffersize) {
1056+
char *newbuffer;
10561057
ptrdiff_t diff = p - *buffer;
10571058
*buffersize *= 2;
1058-
*buffer = (char *)realloc(*buffer, *buffersize);
1059-
if (*buffer == NULL) {
1059+
newbuffer = (char *)realloc(*buffer, *buffersize);
1060+
if (newbuffer == NULL) {
10601061
return NULL;
10611062
}
1063+
*buffer = newbuffer;
10621064
p = *buffer + diff;
10631065
}
10641066

0 commit comments

Comments
 (0)
0