8000 ci: Disable filtering of lint errors. · matplotlib/matplotlib@5cfec07 · GitHub
[go: up one dir, main page]

Skip to content

Commit 5cfec07

Browse files
committed
ci: Disable filtering of lint errors.
For certain reporters, it's necessary to do this filtering because GitHub does not allow posting to unrelated files. The github-check reporter _should_ allow it though, and we want to catch things like unused imports that may not be in the diff.
1 parent 575c37b commit 5cfec07

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

.github/workflows/reviewdog.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@ jobs:
2929
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3030
run: |
3131
flake8 --docstring-convention=all | \
32-
reviewdog -f=pep8 -name=flake8 -tee -reporter=github-check
32+
reviewdog -f=pep8 -name=flake8 \
33+
-tee -reporter=github-check -filter-mode nofilter
3334
3435
eslint:
3536
name: eslint
@@ -40,6 +41,7 @@ jobs:
4041
- name: eslint
4142
uses: reviewdog/action-eslint@v1
4243
with:
44+
filter_mode: nofilter
4345
github_token: ${{ secrets.GITHUB_TOKEN }}
4446
reporter: github-check
4547
workdir: 'lib/matplotlib/backends/web_backend/'

0 commit comments

Comments
 (0)
0