ft2font: Explicitly cast dimensions when creating Python buffer

QuLogic · QuLogic · commit 5970dfb5e020 · 2025-05-20T22:42:38.000-04:00
On WASM, which is wholly 32-bit, casting unsigned int to signed long is
a narrowing conversion, which it seems to treat as an error. The Agg
buffer cannot be over `(1&lt;&lt;23)` in width or height, so this cast is
safe even with the smaller sizes.
diff --git a/src/_backend_agg_wrapper.cpp b/src/_backend_agg_wrapper.cpp
@@ -254,12 +254,12 @@ PYBIND11_MODULE(_backend_agg, m, py::mod_gil_not_used())
 
         .def_buffer([](RendererAgg *renderer) -> py::buffer_info {
             std::vector<py::ssize_t> shape {
-                renderer->get_height(),
-                renderer->get_width(),
+                static_cast<py::ssize_t>(renderer->get_height()),
+                static_cast<py::ssize_t>(renderer->get_width()),
                 4
             };
             std::vector<py::ssize_t> strides {
-                renderer->get_width() * 4,
+                static_cast<py::ssize_t>(renderer->get_width() * 4),
                 4,
                 1
             };

Original file line number	Diff line number	Diff line change
`@@ -254,12 +254,12 @@ PYBIND11_MODULE(_backend_agg, m, py::mod_gil_not_used())`
`254`	`254`
`255`	`255`	`.def_buffer([](RendererAgg *renderer) -> py::buffer_info {`
`256`	`256`	`std::vector<py::ssize_t> shape {`
`257`		`- renderer->get_height(),`
`258`		`- renderer->get_width(),`
	`257`	`+ static_cast<py::ssize_t>(renderer->get_height()),`
	`258`	`+ static_cast<py::ssize_t>(renderer->get_width()),`
`259`	`259`	`4`
`260`	`260`	`};`
`261`	`261`	`std::vector<py::ssize_t> strides {`
`262`		`- renderer->get_width() * 4,`
	`262`	`+ static_cast<py::ssize_t>(renderer->get_width() * 4),`
`263`	`263`	`4,`
`264`	`264`	`1`
`265`	`265`	`};`