MNT: deprecate filled parameter to colorbar

jklymak · jklymak · commit 4bb60f86b98a · 2021-12-12T09:19:15.000+01:00
The *filled* kwarg doesn't directly do anything and filling is
completely controlled by the mappable.

OTOH, maybe we want to reinstate the ability of *filled* to fill
contours?
diff --git a/lib/matplotlib/colorbar.py b/lib/matplotlib/colorbar.py
@@ -370,6 +370,7 @@ class Colorbar:
 
     n_rasterize = 50  # rasterize solids if number of colors >= n_rasterize
 
+    @_api.delete_parameter("3.6", "filled")
     def __init__(self, ax, mappable=None, *, cmap=None,
                  norm=None,
                  alpha=None,
@@ -450,7 +451,7 @@ def __init__(self, ax, mappable=None, *, cmap=None,
         self.spacing = spacing
         self.orientation = orientation
         self.drawedges = drawedges
-        self.filled = filled
+        self._filled = filled
         self.extendfrac = extendfrac
         self.extendrect = extendrect
         self.solids = None
@@ -530,6 +531,8 @@ def _cbar_cla(self):
     # Also remove ._patch after deprecation elapses.
     patch = _api.deprecate_privatize_attribute("3.5", alternative="ax")
 
+    filled = _api.deprecate_privatize_attribute("3.6")
+
     def update_normal(self, mappable):
         """
         Update solid patches, lines, etc.
@@ -599,7 +602,7 @@ def draw_all(self):
         # boundary norms + uniform spacing requires a manual locator.
         self.update_ticks()
 
-        if self.filled:
+        if self._filled:
             ind = np.arange(len(self._values))
             if self._extend_lower():
                 ind = ind[1:]
@@ -671,7 +674,7 @@ def _do_extends(self, extendlen):
 
         # xyout is the path for the spine:
         self.outline.set_xy(xyout)
-        if not self.filled:
+        if not self._filled:
             return
 
         # Make extend triangles or rectangles filled patches.  These are
