MNT: ensure pre-multiplication casting to prevent overflow

tacaswell · tacaswell · commit 49f173d285f5 · 2022-09-06T19:45:55.000-04:00
diff --git a/src/_path.h b/src/_path.h
@@ -1222,7 +1222,7 @@ bool convert_to_string(PathIterator &path,
     clipped_t clipped(nan_removed, do_clip, clip_rect);
     simplify_t simplified(clipped, simplify, path.simplify_threshold());
 
-    buffersize = path.total_vertices() * (precision + 5) * 4;
+    buffersize = (size_t) path.total_vertices() * (precision + 5) * 4;
     if (buffersize == 0) {
         return true;
     }

Original file line number	Diff line number	Diff line change
`@@ -1222,7 +1222,7 @@ bool convert_to_string(PathIterator &path,`
`1222`	`1222`	`clipped_t clipped(nan_removed, do_clip, clip_rect);`
`1223`	`1223`	`simplify_t simplified(clipped, simplify, path.simplify_threshold());`
`1224`	`1224`
`1225`		`- buffersize = path.total_vertices() * (precision + 5) * 4;`
	`1225`	`+ buffersize = ( 48B3 size_t) path.total_vertices() * (precision + 5) * 4;`
`1226`	`1226`	`if (buffersize == 0) {`
`1227`	`1227`	`return true;`
`1228`	`1228`	`}`