Don't push axes state if it wasn't edited.

anntzer · anntzer · commit 486f0b10ab7f · 2016-06-20T19:12:50.000-07:00
Thanks to @tacaswell for fixing the case where the multiple edits are applied consecutively.
diff --git a/lib/matplotlib/backends/qt_editor/figureoptions.py b/lib/matplotlib/backends/qt_editor/figureoptions.py
@@ -45,17 +45,18 @@ def figure_edit(axes, parent=None):
     sep = (None, None)  # separator
 
     # Get / General
-    xmin, xmax = map(float, axes.get_xlim())
-    ymin, ymax = map(float, axes.get_ylim())
+    # Cast to builtin floats as they have nicer reprs.
+    orig_xmin, orig_xmax = map(float, axes.get_xlim())
+    orig_ymin, orig_ymax = map(float, axes.get_ylim())
     general = [('Title', axes.get_title()),
                sep,
                (None, "<b>X-Axis</b>"),
-               ('Min', xmin), ('Max', xmax),
+               ('Min', orig_xmin), ('Max', orig_xmax),
                ('Label', axes.get_xlabel()),
                ('Scale', [axes.get_xscale(), 'linear', 'log']),
                sep,
                (None, "<b>Y-Axis</b>"),
-               ('Min', ymin), ('Max', ymax),
+               ('Min', orig_ymin), ('Max', orig_ymax),
                ('Label', axes.get_ylabel()),
                ('Scale', [axes.get_yscale(), 'linear', 'log']),
                sep,
@@ -166,6 +167,9 @@ def prepare_data(d, init):
 
     def apply_callback(data):
         """This function will be called to apply changes"""
+        orig_xlim = axes.get_xlim()
+        orig_ylim = axes.get_ylim()
+
         general = data.pop(0)
         curves = data.pop(0) if has_curve else []
         images = data.pop(0) if has_image else []
@@ -234,7 +238,8 @@ def apply_callback(data):
         # Redraw
         figure = axes.get_figure()
         figure.canvas.draw()
-        figure.canvas.toolbar.push_current()
+        if not (axes.get_xlim() == orig_xlim and axes.get_ylim() == orig_ylim):
+            figure.canvas.toolbar.push_current()
 
     data = formlayout.fedit(datalist, title="Figure options", parent=parent,
                             icon=get_icon('qt4_editor_options.svg'),
