Backport PR#24488 (Update for pydata-sphinx-theme 0.12.0)

ksunden · QuLogic · commit 3427f2e4b3f9 · 2022-11-19T03:11:07.000-05:00
`pydata-sphinx-theme` updated, renaming some configuration names.
(only one of which we actually configure)
While they are just warnings for now, we are configured to error on
warning so CircleCI is indicating failure.

This does the 'easy' route of just changing to the new name and expecting
the version in which it is implemented.

If desired, I could do a larger change to accomodate both by checking
the version, but I'm also not _too_ worried about more tightly pinning
already relatively tight requirements.
diff --git a/doc/conf.py b/doc/conf.py
@@ -383,7 +383,7 @@ def js_tag_with_cache_busting(js):
              "image_light": "images/logo2.svg",
              "image_dark": "images/logo_dark.svg"},
     "navbar_end": ["theme-switcher", "version-switcher", "mpl_icon_links"],
-    "page_sidebar_items": "page-toc.html",
+    "secondary_sidebar_items": "page-toc.html",
 }
 include_analytics = is_release_build
 if include_analytics:
diff --git a/requirements/doc/doc-requirements.txt b/requirements/doc/doc-requirements.txt
@@ -13,7 +13,7 @@ ipython
 ipywidgets
 numpydoc>=1.0
 packaging>=20
-pydata-sphinx-theme>=0.9.0
+pydata-sphinx-theme>=0.12.0
 mpl-sphinx-theme~=3.6.0
 sphinxcontrib-svg2pdfconverter>=1.1.0
 sphinx-gallery>=0.10

Original file line number	Diff line number	Diff line change
`@@ -383,7 +383,7 @@ def js_tag_with_cache_busting(js):`
`383`	`383`	`"image_light": "images/logo2.svg",`
`384`	`384`	`"image_dark": "images/logo_dark.svg"},`
`385`	`385`	`"navbar_end": ["theme-switcher", "version-switcher", "mpl_icon_links"],`
`386`		`- "page_sidebar_items": "page-toc.html",`
	`386`	`+ "secondary_sidebar_items": "page-toc.html",`
`387`	`387`	`}`
`388`	`388`	`include_analytics = is_release_build`
`389`	`389`	`if include_analytics:`