8000 Merge pull request #17040 from timhoffm/doc-test · matplotlib/matplotlib@30d1396 · GitHub
[go: up one dir, main page]

Skip to content

Commit 30d1396

Browse files
authored
Merge pull request #17040 from timhoffm/doc-test
Improve docs on automated tests
2 parents 52e04f5 + af4469e commit 30d1396

File tree

1 file changed

+30
-9
lines changed

1 file changed

+30
-9
lines changed

doc/devel/coding_guide.rst

Lines changed: 30 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -176,24 +176,45 @@ Merging
176176
A core dev should only champion one PR at a time and we should try to keep
177177
the flow of championed PRs reasonable.
178178

179+
* Do not self merge, except for 'small' patches to un-break the CI or
180+
when another reviewer explicitly allows it (ex, "Approve modulo CI
181+
passing, may self merge when green").
182+
179183
.. _pr-automated-tests:
180184

181185
Automated tests
182186
---------------
183187

184-
* Make sure the Travis, Appveyor, CircleCI, and codecov tests are passing
185-
before merging.
188+
Whenever a pull request is created or updated, various automated test tools
189+
will run on all supported platforms and versions of Python.
190+
191+
* Make sure the Travis, Appveyor, CircleCI, and Azure pipelines are passing
192+
before merging (All checks are listed at the bottom of the GitHub page of
193+
your pull request). Here are some tips for finding the cause of the test
194+
failure:
195+
196+
- If *Travis flake8* fails, you have a code style issue, which will be listed
197+
near the bottom of the *Travis flake8* log.
198+
- If any other Travis run fails, search the log for ``FAILURES``. The
199+
subsequent section will contain information on the failed tests.
200+
- If CircleCI fails, likely you have some reStructuredText style issue in
201+
the docs. Search the CircleCI log for ``WARNING``.
202+
- If Azure pipelines fail with an image comparison error, you can find the
203+
images as *artifacts* of the Azure job:
186204

187-
- Whenever a pull request is created or updated, Travis and Appveyor
188-
automatically runs the test suite on all versions of Python
189-
supported by Matplotlib. The tox_ support in Matplotlib may be
190-
useful for testing locally.
205+
- Click *Details* on the check on the GitHub PR page.
206+
- Click *View more details on Azure Pipelines* to go to Azure.
207+
- On the overview page *artifacts* are listed in the section *Related*.
208+
209+
210+
* Codecov and LGTM are currently for information only. Their failure is not
211+
necessarily a blocker.
212+
213+
* tox_ is not used in the automated testing. It is supported for testing
214+
locally.
191215

192216
.. _tox: https://tox.readthedocs.io/
193217

194-
* Do not self merge, except for 'small' patches to un-break the CI or
195-
when another reviewer explicitly allows it (ex, "Approve modulo CI
196-
passing, may self merge when green").
197218

198219
.. _pr-squashing:
199220

0 commit comments

Comments
 (0)
0