@@ -176,24 +176,45 @@ Merging
176
176
A core dev should only champion one PR at a time and we should try to keep
177
177
the flow of championed PRs reasonable.
178
178
179
+ * Do not self merge, except for 'small' patches to un-break the CI or
180
+ when another reviewer explicitly allows it (ex, "Approve modulo CI
181
+ passing, may self merge when green").
182
+
179
183
.. _pr-automated-tests :
180
184
181
185
Automated tests
182
186
---------------
183
187
184
- * Make sure the Travis, Appveyor, CircleCI, and codecov tests are passing
185
- before merging.
188
+ Whenever a pull request is created or updated, various automated test tools
189
+ will run on all supported platforms and versions of Python.
190
+
191
+ * Make sure the Travis, Appveyor, CircleCI, and Azure pipelines are passing
192
+ before merging (All checks are listed at the bottom of the GitHub page of
193
+ your pull request). Here are some tips for finding the cause of the test
194
+ failure:
195
+
196
+ - If *Travis flake8 * fails, you have a code style issue, which will be listed
197
+ near the bottom of the *Travis flake8 * log.
198
+ - If any other Travis run fails, search the log for ``FAILURES ``. The
199
+ subsequent section will contain information on the failed tests.
200
+ - If CircleCI fails, likely you have some reStructuredText style issue in
201
+ the docs. Search the CircleCI log for ``WARNING ``.
202
+ - If Azure pipelines fail with an image comparison error, you can find the
203
+ images as *artifacts * of the Azure job:
186
204
187
- - Whenever a pull request is created or updated, Travis and Appveyor
188
- automatically runs the test suite on all versions of Python
189
- supported by Matplotlib. The tox _ support in Matplotlib may be
190
- useful for testing locally.
205
+ - Click *Details * on the check on the GitHub PR page.
206
+ - Click *View more details on Azure Pipelines * to go to Azure.
207
+ - On the overview page *artifacts * are listed in the section *Related *.
208
+
209
+
210
+ * Codecov and LGTM are currently for information only. Their failure is not
211
+ necessarily a blocker.
212
+
213
+ * tox _ is not used in the automated testing. It is supported for testing
214
+ locally.
191
215
192
216
.. _tox : https://tox.readthedocs.io/
193
217
194
- * Do not self merge, except for 'small' patches to un-break the CI or
195
- when another reviewer explicitly allows it (ex, "Approve modulo CI
196
- passing, may self merge when green").
197
218
198
219
.. _pr-squashing :
199
220
0 commit comments