Fix text.set(bbox=None).

anntzer · anntzer · commit 2ee109de5205 · 2017-07-30T15:43:09.000-07:00
So far, in

    from pylab import *
    t = plt.text(.5, .5, "foo")
    t.set(bbox=dict(facecolor='red', alpha=0.5))
    # Other stuff, e.g. animation.
    t.set(bbox=None)
    plt.show()

The line `t.set(bbox=None)` has no effect and leaves the previous bbox
(even though `t.set_bbox(None)` would correctly remove it).  Fix by not
dropping the `{"bbox": None}` entry from the kwargs.
diff --git a/lib/matplotlib/text.py b/lib/matplotlib/text.py
@@ -239,10 +239,12 @@ def update(self, kwargs):
         """
         Update properties from a dictionary.
         """
-        bbox = kwargs.pop('bbox', None)
+        # Update bbox last, as it depends on font properties.
+        sentinel = object()  # bbox can be None, so use another sentinel.
+        bbox = kwargs.pop("bbox", sentinel)
         super(Text, self).update(kwargs)
-        if bbox:
-            self.set_bbox(bbox)  # depends on font properties
+        if bbox is not sentinel:
+            self.set_bbox(bbox)
 
     def __getstate__(self):
         d = super(Text, self).__getstate__()
