8000 Addressing more review comments · matplotlib/matplotlib@1b7510d · GitHub
[go: up one dir, main page]

Skip to content

Commit 1b7510d

Browse files
committed
Addressing more review comments
1 parent 270fdde commit 1b7510d

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

doc/devel/coding_guide.rst

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@
1313
Pull request guidelines
1414
***********************
1515

16-
`Pull requests (PRs) on GitHub <https://docs.github.com/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests>`__
16+
`Pull requests (PRs) on GitHub
17+
<https://docs.github.com/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests>`__
1718
are the mechanism for contributing to Matplotlib's code and documentation.
1819

1920
It is recommended to check that your contribution complies with the following
@@ -24,7 +25,8 @@ rules before submitting a pull request:
2425
in the pull request description to ensure that a link is created to the
2526
original issue (e.g. "Closes #8869" or "Fixes #8869"). This will ensure the
2627
original issue mentioned is automatically closed when your PR is merged. See
27-
`the GitHub documentation <https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue>`__
28+
`the GitHub documentation
29+
<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue>`__
2830
for more details.
2931

3032
* Formatting should follow the recommendations of PEP8_, as enforced by
@@ -85,7 +87,7 @@ rules before submitting a pull request:
8587
.. note::
8688

8789
The current state of the Matplotlib code base is not compliant with all
88-
of those guidelines, but we expect that enforcing those constraints on all
90+
of these guidelines, but we expect that enforcing these constraints on all
8991
new contributions will move the overall code base quality in the right
9092
direction.
9193

doc/devel/development_setup.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ Change into this directory before continuing::
5959
For more information on ``git`` and ``GitHub``, check the following resources.
6060

6161
* `Git documentation <https://git-scm.com/doc>`_
62-
* `Git-Contributing to a Project <https://git-scm.com/book/en/v2/GitHub-Contributing-to-a-Project>`_
62+
* `GitHub-Contributing to a Project <https://git-scm.com/book/en/v2/GitHub-Contributing-to-a-Project>`_
6363
* `Introduction to GitHub <https://lab.github.com/githubtraining/introduction-to-github>`_
6464
* :ref:`using-git`
6565
* :ref:`git-resources`

doc/devel/development_workflow.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ why you did it, we recommend the following:
2121
``bugfix-for-issue-14`` or ``refactor-database-code``.
2222
* If you get stuck, reach out on Gitter or
2323
`discourse <https://discourse.matplotlib.org>`__.
24-
* When your ready or need feedback on your code, open a pull request so that the
24+
* When you're ready or need feedback on your code, open a pull request so that the
2525
Matplotlib developers can give feedback and eventually include your suggested
2626
code into the ``main`` branch.
2727

@@ -40,7 +40,7 @@ Update the ``main`` branch
4040

4141
First make sure you have followed :ref:`installing_for_devs`.
4242

43-
From time to time you should fetch the upstream changes from github::
43+
From time to time you should fetch the upstream changes from GitHub::
4444

4545
git fetch upstream
4646

0 commit comments

Comments
 (0)
0