Merge pull request #25104 from anntzer/tkc

jklymak · web-flow · commit 1ad6cbf0098f · 2023-01-30T14:54:48.000-08:00
tk blitting to destroyed canvases should be a noop, not a segfault.
diff --git a/lib/matplotlib/backends/_backend_tk.py b/lib/matplotlib/backends/_backend_tk.py
@@ -61,6 +61,8 @@ def _blit(argsid):
     the ``_blit_args`` dict, since arguments cannot be passed directly.
     """
     photoimage, dataptr, offsets, bboxptr, comp_rule = _blit_args.pop(argsid)
+    if not photoimage.tk.call("info", "commands", photoimage):
+        return
     _tkagg.blit(photoimage.tk.interpaddr(), str(photoimage), dataptr,
                 comp_rule, offsets, bboxptr)
 
diff --git a/lib/matplotlib/tests/test_backend_tk.py b/lib/matplotlib/tests/test_backend_tk.py
@@ -71,7 +71,7 @@ def test_blit():
     import matplotlib.pyplot as plt
     import numpy as np
     import matplotlib.backends.backend_tkagg  # noqa
-    from matplotlib.backends import _tkagg
+    from matplotlib.backends import _backend_tk, _tkagg
 
     fig, ax = plt.subplots()
     photoimage = fig.canvas._tkphoto
@@ -93,6 +93,10 @@ def test_blit():
         except ValueError:
             print("success")
 
+    # Test blitting to a destroyed canvas.
+    plt.close(fig)
+    _backend_tk.blit(photoimage, data, (0, 1, 2, 3))
+
 
 @_isolated_tk_test(success_count=1)
 def test_figuremanager_preserves_host_mainloop():
