8000 Ensure SketchParams is always fully initialized · matplotlib/matplotlib@0e53ac5 · GitHub
[go: up one dir, main page]
Skip to content

Commit 0e53ac5

Browse files
QuLogic
committed
Ensure SketchParams is always fully initialized
This fixes the following errors from valgrind: ``` Conditional jump or move depends on uninitialised value(s) at 0x377C3EE4: UnknownInlinedFun (path_converters.h:1025) by 0x377C3EE4: UnknownInlinedFun (_backend_agg.h:477) by 0x377C3EE4: PyRendererAgg_draw_path(PyRendererAgg*, _object*) [clone .lto_priv.0] (_backend_agg_wrapper.cpp:197) by 0x49E8705: method_vectorcall_VARARGS (descrobject.c:331) by 0x4A03B7B: UnknownInlinedFun (pycore_call.h:92) by 0x4A03B7B: PyObject_Vectorcall (call.c:325) by 0x49ECEA4: _PyEval_EvalFrameDefault (bytecodes.c:2714) by 0x4A2B684: UnknownInlinedFun (call.c:419) by 0x4A2B684: UnknownInlinedFun (pycore_call.h:92) by 0x4A2B684: method_vectorcall (classobject.c:91) by 0x49F1E44: UnknownInlinedFun (call.c:387) by 0x49F1E44: _PyEval_EvalFrameDefault (bytecodes.c:3262) by 0x4A2B684: UnknownInlinedFun (call.c:419) by 0x4A2B684: UnknownInlinedFun (pycore_call.h:92) by 0x4A2B684: method_vectorcall (classobject.c:91) by 0x49F1E44: UnknownInlinedFun (call.c:387) by 0x49F1E44: _PyEval_EvalFrameDefault (bytecodes.c:3262) by 0x4A2B737: UnknownInlinedFun (call.c:419) by 0x4A2B737: UnknownInlinedFun (pycore_call.h:92) by 0x4A2B737: method_vectorcall (classobject.c:61) by 0x4A19144: _PyVectorcall_Call (call.c:283) by 0x49F1E44: UnknownInlinedFun (call.c:387) by 0x49F1E44: _PyEval_EvalFrameDefault (bytecodes.c:3262) by 0x49E6CBA: _PyObject_FastCallDictTstate (call.c:144) Conditional jump or move depends on uninitialised value(s) at 0x377C3F4F: UnknownInlinedFun (path_converters.h:1030) by 0x377C3F4F: UnknownInlinedFun (_backend_agg.h:477) by 0x377C3F4F: PyRendererAgg_draw_path(PyRendererAgg*, _object*) [clone .lto_priv.0] (_backend_agg_wrapper.cpp:197) by 0x49E8705: method_vectorcall_VARARGS (descrobject.c:331) by 0x4A03B7B: UnknownInlinedFun (pycore_call.h:92) by 0x4A03B7B: PyObject_Vectorcall (call.c:325) by 0x49ECEA4: _PyEval_EvalFrameDefault (bytecodes.c:2714) by 0x4A2B684: UnknownInlinedFun (call.c:419) by 0x4A2B684: UnknownInlinedFun (pycore_call.h:92) by 0x4A2B684: method_vectorcall (classobject.c:91) by 0x49F1E44: UnknownInlinedFun (call.c:387) by 0x49F1E44: _PyEval_EvalFrameDefault (bytecodes.c:3262) by 0x4A2B684: UnknownInlinedFun (call.c:419) by 0x4A2B684: UnknownInlinedFun (pycore_call.h:92) by 0x4A2B684: method_vectorcall (classobject.c:91) by 0x49F1E44: UnknownInlinedFun (call.c:387) by 0x49F1E44: _PyEval_EvalFrameDefault (bytecodes.c:3262) by 0x4A2B737: UnknownInlinedFun (call.c:419) by 0x4A2B737: UnknownInlinedFun (pycore_call.h:92) by 0x4A2B737: method_vectorcall (classobject.c:61) by 0x4A19144: _PyVectorcall_Call (call.c:283) by 0x49F1E44: UnknownInlinedFun (call.c:387) by 0x49F1E44: _PyEval_EvalFrameDefault (bytecodes.c:3262) by 0x49E6CBA: _PyObject_FastCallDictTstate (call.c:144) ```
1 parent b01462c commit 0e53ac5

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

‎src/py_converters.cpp‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -453,6 +453,8 @@ int convert_sketch_params(PyObject *obj, void *sketchp)
453453

454454
if (obj == NULL || obj == Py_None) {
455455
sketch->scale = 0.0;
456+
sketch->length = 0.0;
457+
sketch->randomness = 0.0;
456458
} else if (!PyArg_ParseTuple(obj,
457459
"ddd:sketch_params",
458460
&sketch->scale,

0 commit comments

Comments
 (0)
0