8000 Merge pull request #29338 from ianthomas23/29256-webagg-set-window-title · matplotlib/matplotlib@02263ba · GitHub
[go: up one dir, main page]

Skip to content

Commit 02263ba

Browse files
authored
Merge pull request #29338 from ianthomas23/29256-webagg-set-window-title
Use set_window_title rather than set_label to set title of webagg figure
2 parents ebe7c7e + 767979e commit 02263ba

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
Setting titles of figures using webagg backend
2+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3+
4+
Previously when using the ``webagg`` backend the title of a figure was set using
5+
``figure.set_label``. Now it is set using ``figure.canvas.manager.set_window_title``
6+
which is more consistent with other backends.

lib/matplotlib/backends/backend_webagg_core.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -328,10 +328,8 @@ def handle_toolbar_button(self, event):
328328
getattr(self.toolbar, event['name'])()
329329

330330
def handle_refresh(self, event):
331-
figure_label = self.figure.get_label()
332-
if not figure_label:
333-
figure_label = f"Figure {self.manager.num}"
334-
self.send_event('figure_label', label=figure_label)
331+
if self.manager:
332+
self.send_event('figure_label', label=self.manager.get_window_title())
335333
self._force_full = True
336334
if self.toolbar:
337335
# Normal toolbar init would refresh this, but it happens before the

0 commit comments

Comments
 (0)
0