8000 Future incompatibility with MPL · Issue #83 · matplotlib/cmocean · GitHub
[go: up one dir, main page]
Skip to content

Future incompatibility with MPL #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
neutrinoceros opened this issue Aug 20, 2022 · 8 comments · Fixed by #86
Closed

Future incompatibility with MPL #83

neutrinoceros opened this issue Aug 20, 2022 · 8 comments · Fixed by #86

Comments

@neutrinoceros
Copy link
Contributor
neutrinoceros commented Aug 20, 2022 •
edited
Loading

Just wanted to warn you about the pending deprecation of some functions in the matplotlib.cm namespace that are used in cmocean, like register_cmap

matplotlib/matplotlib#23668

If it's any help, here's the patch I wrote to adapt to these deprecations in yt
yt-project/yt#4089

I can also submit a PR here if you lack time for this.
@camUrban
Copy link
camUrban commented Jan 8, 2023

I'm getting a depreciation warning from Matplotlib when I use cmocean because of register_cmap. A bug fix for this issue would be awesome! 😄

@neutrinoceros
Copy link
Contributor Author

@kthyng any chance you could give a status on this ?

@kthyng
Copy link
Contributor
kthyng commented Jan 10, 2023

@neutrinoceros So sorry I've been unresponsive! It's hard to find the time for this at the moment. If you do have the bandwidth for a PR I'll be more responsive. Otherwise I'll aim to work on it in the time frame of the next month. Sorry I can't be faster!

@neutrinoceros
Copy link
Contributor Author

I'm still happy to give it a go. I'm going to aim at delivering a PR before next week !

@neutrinoceros neutrinoceros mentioned this issue Jan 11, 2023
Merged
@kthyng
Copy link
Contributor
kthyng commented Jan 13, 2023

Thanks @neutrinoceros!

@dstansby
Copy link
Member

Any chance a new release can be put out with this fix in it?

@kthyng
Copy link
Contributor
kthyng commented Mar 20, 2023

@dstansby, @neutrinoceros, @camUrban — There is a new release for cmocean on PyPI now! Sorry for the delay — I think I had a plan to do this earlier but didn't end up getting back to it when I thought I would. The new version is still propagating to conda-forge but hopefully will in the next day.

@dstansby
Copy link
Member

Amazing, thanks a lot 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
-->
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: work around pending deprecation warnings in MPL
4 participants
@kthyng @dstansby @neutrinoceros @camUrban
0