8000 feat: move timer deletion from callback to synchronous code · marcelkottmann/esp32-javascript@355d0b8 · GitHub
[go: up one dir, main page]

Skip to content

Commit 355d0b8

Browse files
feat: move timer deletion from callback to synchronous code
1 parent 194fbc0 commit 355d0b8

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

components/esp32-javascript/esp32-javascript.c

-2
Original file line numberDiff line numberDiff line change
@@ -232,8 +232,6 @@ void IRAM_ATTR vTimerCallback(TimerHandle_t xTimer)
232232
js_event_t event;
233233
js_eventlist_t events;
234234

235-
xTimerDelete(xTimer, 0);
236-
237235
el_create_event(&event, EL_TIMER_EVENT_TYPE, (int)xTimer, 0);
238236
events.events_len = 0;
239237
el_add_event(&events, &event);

components/esp32-javascript/modules/esp32-js-eventloop/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ function el_select_next() {
122122
for (let timerIdx = 0; timerIdx < timers.length; timerIdx++) {
123123
if (timers[timerIdx].handle === evt.status) {
124124
nextTimer = timers.splice(timerIdx, 1)[0];
125+
el_removeTimer(nextTimer.handle);
125126
collected.push(nextTimer.fn);
126127
}
127128
}

0 commit comments

Comments
 (0)
0