修改min和max函数。

shengshijun · shengshijun · commit 0c2477d4410c · 2015-03-01T15:10:19.000+08:00
diff --git a/src/main/java/ssj/algorithm/math/MathUtil.java b/src/main/java/ssj/algorithm/math/MathUtil.java
@@ -23,6 +23,7 @@ public static int gcd(int a, int b) {
 
     public static double max(double... vals) {
         Preconditions.checkNotNull(vals, "vals should not be null");
+        Preconditions.checkArgument(vals.length > 0, "vals should not be empty");
         if (vals.length == 0) {
             return 0;
         }
@@ -90,7 +91,7 @@ private static boolean doubleEqual(double one, double two) {
     public static <T extends Comparable<? super T>> T min(T... arr) {
         Preconditions.checkNotNull(arr);
         if (arr.length == 0) {
-            return null;
+            throw new ArithmeticException("too few argument");
         }
 
         T min_value = arr[0];
diff --git a/src/test/java/ssj/algorithm/Main.java b/src/test/java/ssj/algorithm/Main.java
@@ -1,12 +1,17 @@
 package ssj.algorithm;
 
+import ssj.algorithm.math.MathUtil;
+
+import java.lang.reflect.Array;
+import java.util.Arrays;
+
 /**
  * Created by shenshijun on 15/2/1.
  */
 public class Main {
 
     public static void main(String[] args) {
-        System.out.println(Integer.MAX_VALUE + 2L);
-//        int i = 2147483648;
+        Integer[] data = new Integer[]{1, 234};
+        System.out.println(MathUtil.min(data));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@ public static int gcd(int a, int b) {`
`23`	`23`
`24`	`24`	`public static double max(double... vals) {`
`25`	`25`	`Preconditions.checkNotNull(vals, "vals should not be null");`
	`26`	`+ Preconditions.checkArgument(vals.length > 0, "vals should not be empty");`
`26`	`27`	`if (vals.length == 0) {`
`27`	`28`	`return 0;`
`28`	`29`	`}`
`@@ -90,7 +91,7 @@ private static boolean doubleEqual(double one, double two) {`
`90`	`91`	`public static <T extends Comparable<? super T>> T min(T... arr) {`
`91`	`92`	`Preconditions.checkNotNull(arr);`
`92`	`93`	`if (arr.length == 0) {`
`93`		`- return null;`
	`94`	`+ throw new ArithmeticException("too few argument");`
`94`	`95`	`}`
`95`	`96`
`96`	`97`	`T min_value = arr[0];`