[Notifier] Fix two minor issues

fancyweb · fancyweb · commit 4f80d4d63920 · 2020-01-06T11:24:48.000+01:00
diff --git a/src/Symfony/Component/Notifier/Bridge/Nexmo/NexmoTransport.php b/src/Symfony/Component/Notifier/Bridge/Nexmo/NexmoTransport.php
@@ -69,7 +69,7 @@ protected function doSend(MessageInterface $message): void
 
         $result = $response->toArray(false);
         foreach ($result['messages'] as $msg) {
-            if ($msg['status'] ?? 0 > 0) {
+            if ($msg['status'] ?? false) {
                 throw new TransportException(sprintf('Unable to send the SMS: %s (%s).', $msg['error-text'], $msg['status']), $response);
             }
         }
diff --git a/src/Symfony/Component/Notifier/Message/SmsMessage.php b/src/Symfony/Component/Notifier/Message/SmsMessage.php
@@ -37,7 +37,7 @@ public function __construct(string $phone, string $subject)
     public static function fromNotification(Notification $notification, Recipient $recipient, string $transport = null): self
     {
         if (!$recipient instanceof SmsRecipientInterface) {
-            throw new LogicException(sprintf('To send a SMS message, "%s" should implement "%s" or the recipient should implement "%s".', get_class($notification), SmsNotificationInterface::class, SmsRecipientInterface::class));
+            throw new LogicException(sprintf('To send a SMS message, "%s" should implement "%s" or the recipient should implement "%s".', \get_class($notification), SmsNotificationInterface::class, SmsRecipientInterface::class));
         }
 
         return new self($recipient->getPhone(), $notification->getSubject());

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ protected function doSend(MessageInterface $message): void`
`69`	`69`
`70`	`70`	`$result = $response->toArray(false);`
`71`	`71`	`foreach ($result['messages'] as $msg) {`
`72`		`- if ($msg['status'] ?? 0 > 0) {`
	`72`	`+ if ($msg['status'] ?? false) {`
`73`	`73`	`throw new TransportException(sprintf('Unable to send the SMS: %s (%s).', $msg['error-text'], $msg['status']), $response);`
`74`	`74`	`}`
`75`	`75`	`}`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public function __construct(string $phone, string $subject)`
`37`	`37`	`public static function fromNotification(Notification $notification, Recipient $recipient, string $transport = null): self`
`38`	`38`	`{`
`39`	`39`	`if (!$recipient instanceof SmsRecipientInterface) {`
`40`		`- throw new LogicException(sprintf('To send a SMS message, "%s" should implement "%s" or the recipient should implement "%s".', get_class($notification), SmsNotificationInterface::class, SmsRecipientInterface::class));`
	`40`	`+ throw new LogicException(sprintf('To send a SMS message, "%s" should implement "%s" or the recipient should implement "%s".', \get_class($notification), SmsNotificationInterface::class, SmsRecipientInterface::class));`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`return new self($recipient->getPhone(), $notification->getSubject());`