Fixed not free'd heap tuple if BEFORE DELETE trigger procedure

Jan Wieck · Jan Wieck · commit ccf330d67e2f · 1999-02-07T15:13:13.000Z
returns new created tuple instead of the one given to it.

Jan
diff --git a/src/backend/commands/trigger.c b/src/backend/commands/trigger.c
@@ -684,6 +684,8 @@ ExecBRDeleteTriggers(Relation rel, ItemPointer tupleid)
 		newtuple = ExecCallTriggerFunc(trigger[i]);
 		if (newtuple == NULL)
 			break;
+		if (newtuple != trigtuple)
+			pfree(newtuple);
 	}
 	CurrentTriggerData = NULL;
 	pfree(SaveTriggerData);

Original file line number	Diff line number	Diff line change
`@@ -684,6 +684,8 @@ ExecBRDeleteTriggers(Relation rel, ItemPointer tupleid)`
`684`	`684`	`newtuple = ExecCallTriggerFunc(trigger[i]);`
`685`	`685`	`if (newtuple == NULL)`
`686`	`686`	`break;`
	`687`	`+ if (newtuple != trigtuple)`
	`688`	`+ pfree(newtuple);`
`687`	`689`	`}`
`688`	`690`	`CurrentTriggerData = NULL;`
`689`	`691`	`pfree(SaveTriggerData);`