adapt tickon:'boundaries' logic for multicategory axes

etpinard · etpinard · commit d986f9424a36 · 2018-11-30T12:15:10.000-05:00
diff --git a/src/plots/cartesian/axes.js b/src/plots/cartesian/axes.js
@@ -2392,7 +2392,7 @@ axes.drawLabels = function(gd, ax, opts) {
 
             var autoangle = 0;
 
-            if(ax.tickson === 'boundaries') {
+            if(ax.tickson === 'boundaries' && cls === ax._id + 'tick') {
                 var gap = 2;
                 if(ax.ticks) gap += ax.tickwidth / 2;
 
diff --git a/src/plots/cartesian/axis_defaults.js b/src/plots/cartesian/axis_defaults.js
@@ -91,7 +91,9 @@ module.exports = function handleAxisDefaults(containerIn, containerOut, coerce,
     if(options.automargin) coerce('automargin');
 
     if(!options.noTickson &&
-        containerOut.type === 'category' && (containerOut.ticks || containerOut.showgrid)) {
+        (containerOut.type === 'category' || containerOut.type === 'multicategory') &&
+        (containerOut.ticks || containerOut.showgrid)
+    ) {
         coerce('tickson');
     }
 
diff --git a/src/plots/cartesian/layout_attributes.js b/src/plots/cartesian/layout_attributes.js
@@ -323,7 +323,7 @@ module.exports = {
         description: [
             'Determines where ticks and grid lines are drawn with respect to their',
             'corresponding tick labels.',
-            'Only has an effect for axes of `type` *category*.',
+            'Only has an effect for axes of `type` *category* or *multicategory*.',
             'When set to *boundaries*, ticks and grid lines are drawn half a category',
             'to the left/bottom of labels.'
         ].join(' ')

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,9 @@ module.exports = function handleAxisDefaults(containerIn, containerOut, coerce,`
`91`	`91`	`if(options.automargin) coerce('automargin');`
`92`	`92`
`93`	`93`	`if(!options.noTickson &&`
`94`		`- containerOut.type === 'category' && (containerOut.ticks \|\| containerOut.showgrid)) {`
	`94`	`+ (containerOut.type === 'category' \|\| containerOut.type === 'multicategory') &&`
	`95`	`+ (containerOut.ticks \|\| containerOut.showgrid)`
	`96`	`+ ) {`
`95`	`97`	`coerce('tickson');`
`96`	`98`	`}`
`97`	`99`