fixed entity choice list BC break

Burgov · Burgov · commit 231e79ce0fa4 · 2011-12-22T10:49:27.000+01:00
diff --git a/src/Symfony/Bridge/Doctrine/Form/ChoiceList/EntityChoiceList.php b/src/Symfony/Bridge/Doctrine/Form/ChoiceList/EntityChoiceList.php
@@ -103,7 +103,7 @@ public function __construct(ObjectManager $manager, $class, $property = null, En
         // displaying entities as strings
         if ($property) {
             $this->propertyPath = new PropertyPath($property);
-        } elseif (!method_exists($this->class, '__toString')) {
+        } elseif (!method_exists($this->classMetadata->getName(), '__toString')) {
             // Otherwise expect a __toString() method in the entity
             throw new FormException('Entities passed to the choice field must have a "__toString()" method defined (or you can also override the "property" option).');
         }
diff --git a/tests/Symfony/Tests/Bridge/Doctrine/Form/ChoiceList/EntityChoiceListTest.php b/tests/Symfony/Tests/Bridge/Doctrine/Form/ChoiceList/EntityChoiceListTest.php
@@ -196,4 +196,24 @@ public function testGroupByInvalidPropertyPathReturnsFlatChoices()
             2 => 'Bar'
         ), $choiceList->getChoices('choices'));
     }
+
+    public function testPossibleToProviceShorthandEntityName()
+    {
+        $shorthandName = 'FooBarBundle:Bar';
+
+        $metadata = $this->getMockBuilder('Doctrine\ORM\Mapping\ClassMetadata')->disableOriginalConstructor()->getMock();
+        $metadata->expects($this->any())->method('getName')->will($this->returnValue('Symfony\Tests\Bridge\Doctrine\Fixtures\SingleIdentEntity'));
+
+        $em = $this->getMock('Doctrine\Common\Persistence\ObjectManager');
+        $em->expects($this->once())->method('getClassMetaData')->with($shorthandName)->will($this->returnValue($metadata));
+
+        $choiceList = new EntityChoiceList(
+            $em,
+            $shorthandName,
+            null,
+            null,
+            null,
+            null
+        );
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ public function __construct(ObjectManager $manager, $class, $property = null, En`
`103`	`103`	`// displaying entities as strings`
`104`	`104`	`if ($property) {`
`105`	`105`	`$this->propertyPath = new PropertyPath($property);`
`106`		`- } elseif (!method_exists($this->class, '__toString')) {`
	`106`	`+ } elseif (!method_exists($this->classMetadata->getName(), '__toString')) {`
`107`	`107`	`// Otherwise expect a __toString() method in the entity`
`108`	`108`	`throw new FormException('Entities passed to the choice field must have a "__toString()" method defined (or you can also override the "property" option).');`
`109`	`109`	`}`