PyObject.Length no longer returns 0 when it is impossible to determine length

lostmsu · lostmsu · commit ad7f83b026fd · 2020-11-20T18:58:36.000-08:00
diff --git a/src/runtime/pyobject.cs b/src/runtime/pyobject.cs
@@ -657,19 +657,14 @@ public virtual void DelItem(int index)
         /// <summary>
         /// Length Method
         /// </summary>
-        /// <remarks>
-        /// Returns the length for objects that support the Python sequence
-        /// protocol, or 0 if the object does not support the protocol.
-        /// </remarks>
         public virtual long Length()
         {
             DebugUtil.EnsureGIL();
 
             var s = Runtime.PyObject_Size(obj);
             if (s < 0)
             {
-                Runtime.PyErr_Clear();
-                return 0;
+                throw PythonException.ThrowLastAsClrException();
             }
             return s;
         }

Original file line number	Diff line number	Diff line change
`@@ -657,19 +657,14 @@ public virtual void DelItem(int index)`
`657`	`657`	`/// <summary>`
`658`	`658`	`/// Length Method`
`659`	`659`	`/// </summary>`
`660`		`- /// <remarks>`
`661`		`- /// Returns the length for objects that support the Python sequence`
`662`		`- /// protocol, or 0 if the object does not support the protocol.`
`663`		`- /// </remarks>`
`664`	`660`	`public virtual long Length()`
`665`	`661`	`{`
`666`	`662`	`DebugUtil.EnsureGIL();`
`667`	`663`
`668`	`664`	`var s = Runtime.PyObject_Size(obj);`
`669`	`665`	`if (s < 0)`
`670`	`666`	`{`
`671`		`- Runtime.PyErr_Clear();`
`672`		`- return 0;`
	`667`	`+ throw PythonException.ThrowLastAsClrException();`
`673`	`668`	`}`
`674`	`669`	`return s;`
`675`	`670`	`}`