Fixed PythonException leak

amos402 · Martin-Molinero · commit 338dcc184ae3 · 2019-03-27T17:02:26.000-03:00
diff --git a/src/runtime/finalizer.cs b/src/runtime/finalizer.cs
@@ -105,7 +105,7 @@ private void AddPendingCollect()
 
         private int OnPendingCollect(IntPtr arg)
         {
-            Collect();
+            DisposeAll();
             _pending = false;
             return 0;
         }
diff --git a/src/runtime/pythonexception.cs b/src/runtime/pythonexception.cs
@@ -21,9 +21,6 @@ public PythonException()
         {
             IntPtr gs = PythonEngine.AcquireLock();
             Runtime.PyErr_Fetch(ref _pyType, ref _pyValue, ref _pyTB);
-            Runtime.XIncref(_pyType);
-            Runtime.XIncref(_pyValue);
-            Runtime.XIncref(_pyTB);
             if (_pyType != IntPtr.Zero && _pyValue != IntPtr.Zero)
             {
                 string type;

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ private void AddPendingCollect()`
`105`	`105`
`106`	`106`	`private int OnPendingCollect(IntPtr arg)`
`107`	`107`	`{`
`108`		`- Collect();`
	`108`	`+ DisposeAll();`
`109`	`109`	`_pending = false;`
`110`	`110`	`return 0;`
`111`	`111`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,9 +21,6 @@ public PythonException()`
`21`	`21`	`{`
`22`	`22`	`IntPtr gs = PythonEngine.AcquireLock();`
`23`	`23`	`Runtime.PyErr_Fetch(ref _pyType, ref _pyValue, ref _pyTB);`
`24`		`- Runtime.XIncref(_pyType);`
`25`		`- Runtime.XIncref(_pyValue);`
`26`		`- Runtime.XIncref(_pyTB);`
`27`	`24`	`if (_pyType != IntPtr.Zero && _pyValue != IntPtr.Zero)`
`28`	`25`	`{`
`29`	`26`	`string type;`