test_iter_commits

sigmavirus24 · sigmavirus24 · commit 6bc87fbce016 · 2013-01-12T16:18:06.000-05:00
diff --git a/github3/repos.py b/github3/repos.py
@@ -798,7 +798,7 @@ def iter_comments_on_commit(self, sha, number=1):
         url = self._build_url('commits', sha, 'comments', base_url=self._api)
         return self._iter(int(number), url, RepoComment)
 
-    def iter_commits(self, sha='', path='', author='', number=-1):
+    def iter_commits(self, sha=None, path=None, author=None, number=-1):
         """Iterate over commits in this repository.
 
         :param str sha: (optional), sha or branch to start listing commits
@@ -812,13 +812,8 @@ def iter_commits(self, sha='', path='', author='', number=-1):
 
         :returns: list of :class:`RepoCommit <RepoCommit>`\ s
         """
-        params = {}
-        if sha:
-            params['sha'] = sha
-        if path:
-            params['path'] = path
-        if author:
-            params['author'] = author
+        params = {'sha': sha, 'path': path, 'author': author}
+        self._remove_none(params)
         url = self._build_url('commits', base_url=self._api)
         return self._iter(int(number), url, RepoCommit, params=params)
 
diff --git a/tests/test_repos.py b/tests/test_repos.py
@@ -531,3 +531,16 @@ def test_iter_comments_on_commit(self):
         c = next(self.repo.iter_comments_on_commit('fakesha'))
         expect(c).isinstance(github3.repos.RepoComment)
         self.mock_assertions()
+
+    def test_iter_commits(self):
+        self.response('commit', _iter=True)
+        self.get(self.api + 'commits')
+        self.conf = {'params': {}}
+
+        c = next(self.repo.iter_commits())
+        expect(c).isinstance(github3.repos.RepoCommit)
+        self.mock_assertions()
+
+        self.conf = {'params': {'sha': 'fakesha', 'path': '/'}}
+        c = next(self.repo.iter_commits('fakesha', '/'))
+        self.mock_assertions()
