10000
We read every piece of feedback, and take your input very seriously.
1 parent 42c0e44 commit 303f27fCopy full SHA for 303f27f
ports/esp32/modsocket.c
@@ -190,6 +190,34 @@ STATIC void _socket_getaddrinfo(const mp_obj_t addrtuple, struct addrinfo **resp
190
}
191
192
193
+STATIC mp_obj_t socket_make_new(const mp_obj_type_t *type_in, size_t n_args, size_t n_kw, const mp_obj_t *args) {
194
+ mp_arg_check_num(n_args, n_kw, 0, 3, false);
195
+
196
+ socket_obj_t *sock = m_new_obj_with_finaliser(socket_obj_t);
197
+ sock->base.type = type_in;
198
+ sock->domain = AF_INET;
199
+ sock->type = SOCK_STREAM;
200
+ sock->proto = 0;
201
+ sock->peer_closed = false;
202
+ if (n_args > 0) {
203
+ sock->domain = mp_obj_get_int(args[0]);
204
+ if (n_args > 1) {
205
+ sock->type = mp_obj_get_int(args[1]);
206
+ if (n_args > 2) {
207
+ sock->proto = mp_obj_get_int(args[2]);
208
+ }
209
210
211
212
+ sock->fd = lwip_socket(sock->domain, sock->type, sock->proto);
213
+ if (sock->fd < 0) {
214
+ exception_from_errno(errno);
215
216
+ _socket_settimeout(sock, UINT64_MAX);
217
218
+ return MP_OBJ_FROM_PTR(sock);
219
+}
220
221
STATIC mp_obj_t socket_bind(const mp_obj_t arg0, const mp_obj_t arg1) {
222
socket_obj_t *self = MP_OBJ_TO_PTR(arg0);
223
struct addrinfo *res;
@@ -622,37 +650,11 @@ STATIC const mp_stream_p_t socket_stream_p = {
622
650
STATIC const mp_obj_type_t socket_type = {
623
651
{ &mp_type_type },
624
652
.name = MP_QSTR_socket,
653
+ .make_new = socket_make_new,
625
654
.protocol = &socket_stream_p,
626
655
.locals_dict = (mp_obj_t)&socket_locals_dict,
627
656
};
628
657
629
-STATIC mp_obj_t get_socket(size_t n_args, const mp_obj_t *args) {
630
- socket_obj_t *sock = m_new_obj_with_finaliser(socket_obj_t);
631
- sock->base.type = &socket_type;
632
- sock->domain = AF_INET;
633
- sock->type = SOCK_STREAM;
634
- sock->proto = 0;
635
- sock->peer_closed = false;
636
- if (n_args > 0) {
637
- sock->domain = mp_obj_get_int(args[0]);
638
- if (n_args > 1) {
639
- sock->type = mp_obj_get_int(args[1]);
640
- if (n_args > 2) {
641
- sock->proto = mp_obj_get_int(args[2]);
642
- }
643
644
645
-
646
- sock->fd = lwip_socket(sock->domain, sock->type, sock->proto);
647
- if (sock->fd < 0) {
648
- exception_from_errno(errno);
649
- _socket_settimeout(sock, UINT64_MAX);
- return MP_OBJ_FROM_PTR(sock);
-}
-STATIC MP_DEFINE_CONST_FUN_OBJ_VAR_BETWEEN(get_socket_obj, 0, 3, get_socket);
658
STATIC mp_obj_t esp_socket_getaddrinfo(size_t n_args, const mp_obj_t *args) {
659
// TODO support additional args beyond the first two
660
@@ -703,7 +705,7 @@ STATIC MP_DEFINE_CONST_FUN_OBJ_0(esp_socket_initialize_obj, esp_socket_initializ
703
705
STATIC const mp_rom_map_elem_t mp_module_socket_globals_table[] = {
704
706
{ MP_ROM_QSTR(MP_QSTR___name__), MP_ROM_QSTR(MP_QSTR_usocket) },
707
{ MP_ROM_QSTR(MP_QSTR___init__), MP_ROM_PTR(&esp_socket_initialize_obj) },
- { MP_ROM_QSTR(MP_QSTR_socket), MP_ROM_PTR(&get_socket_obj) },
708
+ { MP_ROM_QSTR(MP_QSTR_socket), MP_ROM_PTR(&socket_type) },
709
{ MP_ROM_QSTR(MP_QSTR_getaddrinfo), MP_ROM_PTR(&esp_socket_getaddrinfo_obj) },
710
711
{ MP_ROM_QSTR(MP_QSTR_AF_INET), MP_ROM_INT(AF_INET) },